Hybrid View

    Success! Looks like we've fixed this one. According to our records the fix was applied for EXTGWT-2758 in 3.1 beta.
  1. #1
    Sencha User
    Join Date
    Dec 2012
    Posts
    11
    Vote Rating
    0
    ChristopheF is on a distinguished road

      0  

    Default Info.display(String, String)

    Info.display(String, String)


    Hello !

    I have found a "bug" in your Info class : Your method "display" is expecting two Strings, but it's not written anywhere (nothing in the Javadoc) that these strings are supposed to be HTML constants.

    If I do this :

    Info.display("<epic>", "<fail>");

    The application crashes, because in the method "render" of "DefaultInfoConfigDefaultAppearance", you assume, for some reason, that these Strings are HTML constants, which is not enforced anywhere.

    Instead, I really think that you should change the header of your "display" method to : "public static void display(SafeHtml title, SafeHtml text)".

    Have a good day

  2. #2
    Sencha - GXT Dev Team
    Join Date
    Feb 2009
    Location
    Minnesota
    Posts
    2,731
    Vote Rating
    90
    Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light

      0  

    Default


    Thanks for the report. I agree that we should be more explicit in what this method does, through documentation, better method names, or different types in those methods.

    Renaming display(String, String) to follow other methods like ContentPanel.setHeadingHtml/setHeadingText would be a breaking change, so cannot be done before 3.1. Likewise, changing its behavior to now escape strings where it used to allow them normally, so instead we'll better document them in the short term, and add a SafeHtml variant to make it easier to use safely. And just as we support ContentPanel.setHeadingHtml(String), we will probably continue to support strings, as Info.displayHtml(String, String) or the like.

  3. #3
    Sencha - GXT Dev Team
    Join Date
    Feb 2009
    Location
    Minnesota
    Posts
    2,731
    Vote Rating
    90
    Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light

      0  

    Default


    Thanks again for the report - a fix for this is now in the 3.1 branch. This is a breaking change, and for the time being we are only supporting these three methods:

    Info.display(InfoConfig)
    Info.display(String, String)
    Info.display(SafeHtml, SafeHtml)

    Additionally, the InfoConfig subclass DefaultInfoConfig has setters that support html as well as text, and the getters return just SafeHtml. These are breaking changes, as noted, so will only be available in 3.1 so that applications that depend on 3.0 can continue to get bug fixes without breaking code.

Thread Participants: 1

Turkiyenin en sevilen filmlerinin yer aldigi xnxx internet sitemiz olan ve porn sex tarzi bir site olan mobil porno izle sitemiz gercekten dillere destan bir durumda herkesin sevdigi bir site olarak tarihe gececege benziyor. Sitenin en belirgin ozelliklerinden birisi de Turkiyede gercekten kaliteli ve muntazam, duzenli porno izle siteleri olmamasidir. Bu yuzden iste. Ayrica en net goruntu kalitesine sahip adresinde yayinlanmaktadir. Mesela diğer sitelerimizden bahsedecek olursak, en iyi hd porno video arşivine sahip bir siteyiz. "The Best anal porn videos and slut anus, big asses movies set..." hd porno faketaxi