[4.2.0.265] Store "add" event firing contract changed

[mankz]

Ext.data.Store does:

 add: function(arg) {

        
        if (Ext.isArray(arg)) {
            records = arg;
        } else {
            records = arguments;  // BOOOOOOOOH
        }

Should normalize it to real array. Any 'instanceof Array' or Ext.isArray checks on the Records param fails now... Docs would also be lying right now since they state it should be an Array of records.

[evant]

Care to elaborate? At what point are you overriding it?

[mankz]

Well, we have code similar to:

store.on({
    add : refresh,
    update : refresh,
    remove : refresh
})

In the refresh method, we normalize to Array based on

 refresh: function (store, records) {
        var toDraw  = [];

        if (!Ext.isArray(records)) {
            records = [records];
        }

4.2.0.265 breaks this, don't think we're the only ones.

[evant]

Ah, so you're saying the problem is with what's fired by the event/return value? If so, that's already taken care of: EXTJSIV-8201 for your reference.