TreeStore sends DELETE request for phantom nodes

[emixion]

REQUIRED INFORMATION
Ext version tested:

• Ext 4.1.1

Browser versions tested against:

• Chrome 25

DOCTYPE tested against:

• HTML

Description:

• A DELETE request is sent for phantom nodes (nodes not known remotely yet) on manual sync.

Steps to reproduce the problem:

• create a treestore with REST proxy
• create a treepanel using that store
• create a new node
• append that node to the tree rootnode
• remove that node again
• sync the treestore

The result that was expected:

• Not any HTTP request

The result that occurs instead:

• A DELETE HTTP request for the new node

Test Case:

// define the REST store
var store = Ext.create('Ext.data.TreeStore', {
    proxy: {
        type: 'rest',
        url: 'test-nodes.json',
        appendId: false,
        reader: {type: 'json', root: 'data'},
        writer: {type: 'json'}
    }
    ,root: {
        text: 'root',
        id: 'root-1',
        expanded: true
    }
});


// create the tree
var tree = Ext.create('Ext.tree.Panel', {
    store: store
    ,title: 'sync phantom records test'
    ,renderTo: 'tree-example'
});


//add a new node, remove it, sync
var newNode = store.model.create({text: 'dont sync me, im a ghost'}),
    root = tree.getRootNode();
console.log('new node is phantom:', node.phantom);
root.appendChild(newNode);
root.removeChild(newNode);
store.sync(); // <--- a DELETE request for a node not known on the server is sent 

HELPFUL INFORMATION
Testcase:

• attached

Possible fix:
Ext.data.TreeStore.onNodeRemove does this:

if (!node.isReplace && Ext.Array.indexOf(removed, node) == -1) 
    removed.push(node); 

But perhaps it should check for phantom. I have no idea what "isReplace" is supposed to mean.

if (!node.phantom && Ext.Array.indexOf(removed, node) == -1) 
    removed.push(node); 

Additional CSS used:

• only default ext-all.css
• custom css (include details)

Related posts:

• http://www.sencha.com/forum/showthread.php?205955
• http://www.sencha.com/forum/showthread.php?210588

[mitchellsimoens]

Thanks for the report! I have opened a bug in our bug tracker.

[evant]

This isn't a bug.

The record is not a phantom because you have explicitly given it an identifier. That is what indicates whether or not it's a phantom.

As you've suggested, the current code reads:

isNotPhantom = record.phantom !== true;
// don't push phantom records onto removed
if (!isMove && isNotPhantom) {
    // ....
}

[emixion]

Aha, how short sighted of me, sorry. I corrected it in the test case, but it still goes wrong. The remove function of Ext.data.Store does it's job correctly and skips the record. But the onNodeRemove handler of Ext.data.TreeStore still pushes the node onto the 'removed' list.

[emixion]

Ext.define('CVB.data.TreeStore', {
    override: 'Ext.data.TreeStore'
    
    ,onNodeRemove: function(parent, node, isMove)
    {
        node.isReplace = node.phantom;
        this.callParent([parent, node, isMove]);
    }
});