Looks like we can't reproduce the issue or there's a problem in the test case provided.
  1. #1
    Ext GWT Premium Member
    Join Date
    Apr 2011
    Posts
    14
    Vote Rating
    1
    JHammann is on a distinguished road

      0  

    Default Filter Grid: Indicator of a filtered column is lost

    Filter Grid: Indicator of a filtered column is lost


    Hello,

    we are using filtered grids of GXT 3.0.3. As of the last release the head of filtered columns are marked (bold and italic). If we hide the filtered column via the column's menu and show the column again, the marker is lost - i.e. the header will be shown in normal text.

    While debugging the source code, we found the method bindColumnModel() in package com.sencha.gxt.widget.core.client.grid.filters. I think this method contains the problem.

    Code:
      protected void bindColumnModel(ColumnModel<M> columnModel) {
        if (this.columnModel != null) {
          columnHandlerRegistration = this.columnModel.addColumnHiddenChangeHandler(columnHandler);
        }
        if (columnModel != null && columnHandlerRegistration != null) {
          columnHandlerRegistration.removeHandler();
        }
        this.columnModel = columnModel;
    
    
      }
    The registration of the ColumnHiddenChangeHandler will never be processed. The if-clause tests for this.columnModel. But this member will be set at the end of this method. Thus at the beginning of the method this.columnModel is always null.

    Best regards

    Jochen.

  2. #2
    Sencha - GXT Dev Team
    Join Date
    Feb 2009
    Location
    Minnesota
    Posts
    2,734
    Vote Rating
    90
    Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light

      0  

    Default


    Thanks for the report! I agree that this code doesn't make much sense as is, and we'll look into fixing it.

  3. #3
    Sencha - GXT Dev Team
    Join Date
    Feb 2009
    Location
    Minnesota
    Posts
    2,734
    Vote Rating
    90
    Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light

      0  

    Default


    I've cleaned up that code to ensure that the old handler is removed only if there used to be a column model, then restoring it later on, but this doesn't fix the bug that you've reported, it only makes sure that updateColumnHeadings() gets called. Something else is preventing that method from properly re-applying the filtered state. I'm still looking into it, and will update this with any workaround or when a fix is available.

  4. #4
    Sencha - GXT Dev Team
    Join Date
    Feb 2009
    Location
    Minnesota
    Posts
    2,734
    Vote Rating
    90
    Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light

      0  

    Default


    Both the reported issue and the mis-ordered code have been fixed in SVN and in the nightly build, but our QA has found one more case where a similar issue can be reproduced. We intend to fix this issue as well before the next release.

  5. #5
    Sencha Premium Member
    Join Date
    Jan 2013
    Posts
    11
    Vote Rating
    0
    aspadev is on a distinguished road

      0  

    Default Indication of filtered column lost if you group by another column in the grid.

    Indication of filtered column lost if you group by another column in the grid.


    This indication that a column has been filtered on is also lost if you group by any other column in the grid. (Hopefully this is what you have already spotted and are addressing).

  6. #6
    Sencha - GXT Dev Team
    Join Date
    Feb 2009
    Location
    Minnesota
    Posts
    2,734
    Vote Rating
    90
    Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light

      0  

    Default


    Thanks, that's one that isn't covered in our examples, and is not yet fixed. There is at least one other case as well that is still broken (something to do with re-attaching or re-sizing the grid) that are keeping this issue still opened.

    3.0.4 will ship with the initial two cases fixed, and these remaining cases will be dealt with in a later release. We'll post updates this thread with fixes to these related cases when they are available.

  7. #7
    Sencha - GXT Dev Team
    Join Date
    Feb 2009
    Location
    Minnesota
    Posts
    2,734
    Vote Rating
    90
    Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light

      0  

    Default


    We've addressed several more ways to reproduce this - from my review of the code, we should have all of them dealt with now. I am marking this issue as fixed - it is available now in nightly builds, and will be available in the next release.

  8. #8
    Ext GWT Premium Member
    Join Date
    Apr 2011
    Posts
    14
    Vote Rating
    1
    JHammann is on a distinguished road

      0  

    Default


    Thank you very much.


    Regards

    Jochen.

  9. #9
    Sencha User
    Join Date
    Jul 2011
    Posts
    139
    Vote Rating
    14
    Andreas Samjeske will become famous soon enough

      0  

    Default


    I am still expirencing this problem on some grids in GXT3.1.0:
    I activate a filter, header is bold and italic since css class GMTT4CSBGMB-com-sencha-gxt-theme-base-client-grid-ColumnHeaderDefaultAppearance-DefaultColumnHeaderStyles-headInner GMTT4CSBCOB-com-sencha-gxt-theme-base-client-grid-GridFiltersDefaultAppearance-GridFiltersStyle-filtered has been added to div in header of that column.
    After swithching to another Tab of TabPanel and back filter is still active, but header doesn't show it since above mentioned class is not present.

  10. #10
    Sencha - GXT Dev Team
    Join Date
    Jan 2012
    Location
    Arlington, WA
    Posts
    492
    Vote Rating
    15
    branflake2267 will become famous soon enough

      0  

    Default


    Could I get a couple screenshots, just to make sure I'm on the right page?
    Thanks,
    Brandon
    GXT Support

    ~ New GXT Guides ~
    http://docs.sencha.com/gxt/3.1/

    ~ Support Tickets ~
    https://support.sencha.com/index.php

    ~ Tips and Announcements Community ~
    https://plus.google.com/communities/110447085143928405373

    ~Training~
    Get on the Fast Track with Sencha Training http://sencha.com/training