Why new nodes are registered by their internalId's only ?

[sasklacz]

I was investigating some bug that appeared after switching from 4.1.3 to 4.2 regarding Tree structures, and I've found this change in the source:

4.1.3

    registerNode : function(node, includeChildren) {
        var me = this;

        me.nodeHash[node.getId() || node.internalId] = node;
        (...)
    }

4.2

    registerNode : function(node, includeChildren) {
        var me = this,
            children, length, i;

        me.nodeHash[node.internalId] = node;
        (...)
    },

I'm wondering what is the advantage of the second approach ? In this case finding nodes by Id's won't work anymore. What if I'm adding a node with know Id and I want to reference it after adding to the structure ? I'm not considering this a bug but rather I'm interested what was the idea behind this change.

[mitchellsimoens]

I think we were moving to have 2 maps, one for internal id and the other for user defined but I have opened a bug in our bug tracker to make sure this gets look at.

[evant]

The internalId of a model will be set appropriately if you pass an id to it:

Ext.define('Foo', {
    extend: 'Ext.data.Model',
    
    fields: ['id', 'name']    
});

Ext.onReady(function(){
    
    var a = new Foo({
        id: 1
    });
    
    var b = new Foo();
    
    console.log(a.internalId, b.internalId);
    // Logs 1 "ext-record-1" 
});

There's also code to handle the id on the model being changed so it can notify any interested parties, which will be part of the next release.