Using persistenceProperty breaks Grid in 4.2.0.489 RC

[omarc]

I tried using the persistenceProperty option in Ext.data.Model, and when I do, the Grid Panel stops displaying data.

I traced the problem back to Ext.view.Table in the renderCell function, fieldValue is obtained by:

fieldValue = record.data[column.dataIndex]

when it should use:

fieldValue = record.get(column.dataIndex)

Also, in Ext.grid.column.Template, defaultRenderer:

var data = Ext.apply({}, record.data, record.getAssociatedData());

should be:

var data = record.getData(true);

Changing this fixes the problem. I have not looked at what other classes use the same way of accessing the data, there may be others.

This also opens the door to the Grid Panel supporting nested keys in dataIndex, if the Ext.data.Model get function is replaced with:

    get: function(field) {
        if (!field) {
            return null;
        }

        var numKeys = field.indexOf('.'),
            record = this,
            keys, key, i, association;

        if (numKeys < 0) {
            //Non-nested key
            return this[this.persistenceProperty][field];
        } else {
            //Nested key
            keys = field.split('.');

            for (i in keys) {
                key = keys[i];
                association = record.associations.get(key);

                if (association) {
                    record = record[association.instanceName];

                    if (!record) {
                        return null;
                    }
                } else {
                    return record.get(key);
                }
            }
        }
    },

This is very neat since now I can display data that forms part of a hasOne association within a grid, for example:

    Ext.create('Ext.grid.Panel', {
        renderTo: Ext.getBody(),
        height: 250,
        columns: [
            {dataIndex: 'firstName', flex: 1,  header: 'First Name'},
            {dataIndex: 'lastName', flex: 1, header: 'Last Name'},

            //Column displays data from a hasOne association:
            {dataIndex: 'primaryAddress.address1', flex: 1, header: 'Address'}
        ]
    });

I think it would also make sense to have Ext.data.Model.set support nested keys.

Let me know any comments,

Omar

[mitchellsimoens]

Thanks for the report.

[mankz]

Curious, what's the use case of using 'persistenceProperty'?

[evant]

Not a lot, TBH I'm not sure why it was implemented in the first place.

[mankz]

Maybe having one more layer of abstraction added to Ext.data.Model would be great?

persistencePropertyProperty : 'persistenceProperty'

[dongryphon]

Or maybe

   config: {
       persistencePropertyProperty: 'persistenceProperty'
   }

For good measure? ;P

[omarc]

I agree, I don't see much use to the option, however any class other than Ext.data.Model shouldn't really access the data object directly should they? Especially if we have the get and getData methods in Ext.data.Model.

[dongryphon]

The problem is one of performance really - for 4.2 we revamped the entire grid rendering pipeline to make the scrolling experience as smooth as possible. I suspect this is why this may have changed, but we do need to get away from this config because it presents some serious performance problems in data and its consumers.

So apologies for any hassle there.