Ext.device.notification.PhoneGap broken

[Kurt001]

Hi there,

the PhoneGap notification is not working, because its broken at several points.

VERSION
Sencha Touch 2.1.1

FILE
Ext.device.notification.PhoneGap

REPRODUCTION
Add anywhere:

Ext.device.Notifcation.show({
    title: 'foo',
    message: 'bar',
    buttons: Ext.MessageBox.OKCANCEL,
    callback: function() {alert('closed')}
});

RESULT
1) button is written as buton
2) buttons are not shown, as the buttons are passed in the wrong way
3) callback throws an error, as it tries to make an array to lowercase

EXPECTED RESULT
Show a native popup and call the callback fn at the end.

WORKING CODE

    show: function () {
        var config = this.callParent(arguments),
            buttons = (config.buttons),
            onShowCallback = function (index) {
                if (config.callback) {
                    config.callback.apply(config.scope, (config.buttons) ? [config.buttons[index - 1].itemId.toLowerCase()] : []);
                }
            };


        // change Ext.MessageBox buttons into normal arrays
        var ln = buttons.length;
        if (ln && typeof buttons[0] != "string") {
            var newButtons = [],
                i;


            for (i = 0; i < ln; i++) {
                newButtons.push(buttons[i].text);
            }


            buttons = newButtons.join(',');
        }


        navigator.notification.confirm(
            config.message, // message
            onShowCallback, // callback
            config.title, // title
            buttons // array of button names
        );


    }

[mitchellsimoens]

Thanks for the report! I have opened a bug in our bug tracker.