Success! Looks like we've fixed this one. According to our records the fix was applied for EXTGWT-3144 in 2.3.1.
  1. #1
    Ext GWT Premium Member
    Join Date
    Mar 2009
    Posts
    226
    Vote Rating
    3
    The_Jackal is on a distinguished road

      1  

    Default Grid with spanning heading bug - headers get the wrong width don't align [2.3] r2490

    Grid with spanning heading bug - headers get the wrong width don't align [2.3] r2490


    Hi,

    Revision 2490 added an adjustWidths() method in the ColumnHeading.java class. Unfortunately it fails when applied to Heading Groups (headings that have two rows). Some column headers on the second row are applied widths from the wrong column. If you set custom widths on each column it becomes obvious as the column headings get out of alignment with the rest of the column.

    It's easy to see the error in the code when debugging.

    Here is a scenario:

    ABB
    ACD

    Row0 has a cell A that spans two rows, then a cell B that effectively spans the two cols (C & D) in the second row.

    The adjustWidths() code will correctly apply the widths of A and then B (as a total of C&D). But then on row 2 there are really only 2 cells C & D as cell A belongs the first row (as it has a row span set). The adjustWidths() does not account for this and applies the width of A to the first cell (C) and then the width of C to the second cell D.

    The code needs to check if rows above have rowspans and if so pick the next column config from the ColumnModel to get the right width.

    I'll get an example a.s.a.p, but all our grids with header groups broke when we upgraded to 2.3 because of this (revision 2489 was only available in 2.3).

    Please don't ignore this - either remove the adjustWidths() or make sure that the row spanning cells are skipped for the rows they span. It's a glaring error when custom widths are set on columns.

    What to see how bad it looks? Ouch!HeaderGroupBugInGXTRev2489.JPG

    So... I've seen a bit of bad press that sometimes bugs aren't fixed in Sencha products. Well prove them wrong! Be a hero and fix this one! (and maybe the long outstanding ComboBox force selection bug for extra awesomeness...)

    Regards,
    Carl Pritchett
    Last edited by The_Jackal; 11 Jun 2013 at 4:07 PM. Reason: Updated revision to 2490

  2. #2
    Sencha User
    Join Date
    Jul 2013
    Posts
    1
    Vote Rating
    0
    irepnikov is on a distinguished road

      0  

    Default


    What's about prioritize and schedule to fix?

  3. #3
    Sencha - GXT Dev Team
    Join Date
    Jan 2012
    Location
    Arlington, WA
    Posts
    460
    Vote Rating
    15
    branflake2267 will become famous soon enough

      0  

    Default


    Thanks for the report! I have opened a bug in our bug tracker.

  4. #4
    Sencha User
    Join Date
    Dec 2010
    Posts
    8
    Vote Rating
    0
    mgrouch2 is on a distinguished road

      0  

    Default We also have same issue. Somehow it works fine in FireFox but not in IE9

    We also have same issue. Somehow it works fine in FireFox but not in IE9


    Is there any update on it?
    Thanks

  5. #5
    Sencha - GXT Dev Team
    Join Date
    Feb 2009
    Location
    Minnesota
    Posts
    2,734
    Vote Rating
    90
    Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light

      0  

    Default


    This appears to be fixed in SVN and the nightly builds, and will go out in 2.3.1.