Success! Looks like we've fixed this one. According to our records the fix was applied for EXTGWT-3191 in 3.0.7.
  1. #1
    Sencha Premium Member
    Join Date
    Feb 2012
    Posts
    16
    Vote Rating
    3
    dkay is on a distinguished road

      0  

    Default Issue when using a ComboBox as an Editor for a GridInlineEditing instance

    Issue when using a ComboBox as an Editor for a GridInlineEditing instance


    Required Information

    Version(s) of Ext GWT
    «Ext GWT 3.0.6»

    Browser versions and OS
    (and desktop environment, if applicable)
    • «Internet Explorer 9, Windows 7 Ultimate»
    • «Firefox 23, Windows 7 Ultimate»
    • «I think any other browser»


    Virtual Machine
    «No»

    Description
    When a ComboBox instance without a custom PropertyEditor is added to a GridInlineEditing instance, then the item which is currently selected remains hightlighted even when the mouse hovers over the other items from the item list.

    But it is still possible to select an item from the item list, even that the item
    under the mouse pointer is not highlighted.

    Run mode
    I tested in development mode only. I assume it will also occur in production mode

    Steps to reproduce the problem
    1. Create a Grid instance
    2. Create a GridInlineEditing instance
    3. Add a ComboBox without some items in the ListStore without setting a custom PropertyEditor
    4. Connect the GridInlineEditing instance with the Grid instance
    5. Open the editor and try to highlight items by hovering other them


    Expected result
    That items unter the mouse pointer are highlighted.

    Actual result
    That the already selected item remains highlighted even that the mouse hovers over other items.

    Test case
    Apply this patch to your Examples project and try it out for yourself
    Code:
    Index: com.sencha.gxt.examples/src/main/java/com/sencha/gxt/explorer/client/grid/AbstractGridEditingExample.java
    ===================================================================
    --- com.sencha.gxt.examples/src/main/java/com/sencha/gxt/explorer/client/grid/AbstractGridEditingExample.java 2013-08-08 14:37:15.008168087 +0200
    +++ com.sencha.gxt.examples/src/main/java/com/sencha/gxt/explorer/client/grid/AbstractGridEditingExample.java      2013-08-08 14:40:08.080173684 +0200
    @@ -155,18 +155,6 @@
    
           SimpleComboBox<Light> combo = new SimpleComboBox<Light>(new StringLabelProvider<Light>());
           combo.setClearValueOnParseError(false);
    -      combo.setPropertyEditor(new PropertyEditor<Light>() {
    -
    -        @Override
    -        public Light parse(CharSequence text) throws ParseException {
    -          return Light.parseString(text.toString());
    -        }
    -
    -        @Override
    -        public String render(Light object) {
    -          return object == null ? Light.SUNNY.toString() : object.toString();
    -        }
    -      });
           combo.setTriggerAction(TriggerAction.ALL);
           combo.add(Light.SUNNY);
           combo.add(Light.MOSTLYSUNNY);
    Helpful Information
    The incorrect highlighting seems to have been introduced by the addition of the startMonitoring() method of the AbstractGridEditingclass which perodically calls the method parse() of the default PropertyEditor class of the ComboBoxCell class which calls the selectByValue() method which does the damage.

    As a workaround I will try to disable this new feature from all GridInlineEditing instances.

    Possible fix
    «Not provided»
    Last edited by dkay; 8 Aug 2013 at 4:55 AM. Reason: edited patch

  2. #2
    Sencha Premium Member
    Join Date
    Feb 2012
    Posts
    16
    Vote Rating
    3
    dkay is on a distinguished road

      0  

    Default Any news on this?

    Any news on this?


    Shall I create an EntryPoint for this?

  3. #3
    Sencha - GXT Dev Team
    Join Date
    Feb 2009
    Location
    Minnesota
    Posts
    2,731
    Vote Rating
    90
    Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light Colin Alworth is a glorious beacon of light

      0  

    Default


    Thanks for the report and sorry for the delay on reviewing this. This appears to have been introduced by the extra validation added to inline editing as you indicated, which apparently causes the field to re-apply its selection.

    We'll update this report when we have a fix - for now, turning off the monitoring feature is a good workaround by calling editing.setMonitorValid(false);. This should have been the default for inline editor - our apologies for the oversight.

  4. #4
    Sencha User
    Join Date
    Sep 2013
    Location
    Minneapolis, MN
    Posts
    2
    Vote Rating
    0
    JonEinTheCities is on a distinguished road

      0  

    Default GridRowEditing

    GridRowEditing


    You may already be aware of this as they both inherit from the AbstractGridEditing class, but this issue also occurs with the GridRowEditing class. While the workaround you provided does prevent the issue, it also leaves the Save button enabled when you first add a new row. Usually it is disabled until the user enters the required information.

  5. #5
    Sencha - GXT Dev Team
    Join Date
    Jan 2012
    Location
    Arlington, WA
    Posts
    380
    Vote Rating
    15
    branflake2267 will become famous soon enough

      0  

    Default


    Just an update, GXT 3.0.7 has been released with this issue fixed in it.

    It can be downloaded:
    https://support.sencha.com/index.php#dash
    or
    http://docs.sencha.com/gxt/3.1/getti...ven/Maven.html
    Thanks,
    Brandon
    GXT Support

    ~ New GXT Guides ~
    http://docs.sencha.com/gxt/3.1/

    ~ Support Tickets ~
    https://support.sencha.com/index.php

    ~ Tips and Announcements Community ~
    https://plus.google.com/communities/110447085143928405373

    ~Training~
    Get on the Fast Track with Sencha Training http://sencha.com/training