Thank you for reporting this bug. We will make it our priority to review this report.
  1. #1
    Ext JS Premium Member simeon's Avatar
    Join Date
    Mar 2007
    Location
    Austin, Texas
    Posts
    227
    Vote Rating
    1
    simeon is on a distinguished road

      0  

    Default Enter key does not open row editor in 4.2.2

    Enter key does not open row editor in 4.2.2


    In 4.2.1 hitting the enter key on a grid row opened the row editor.
    In 4.2.2 it does not open the row Editor

    See Ext Examples:
    http://docs.sencha.com/extjs/4.2.1/#...l/restful.html
    http://docs.sencha.com/extjs/4.2.2/#...l/restful.html


    Chrome latest on a mac

  2. #2
    Sencha - Support Team scottmartin's Avatar
    Join Date
    Jul 2010
    Location
    Houston, Tx
    Posts
    8,990
    Vote Rating
    455
    scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future

      0  

    Default


    This has been corrected in the latest nightly build.

  3. #3
    Ext JS Premium Member simeon's Avatar
    Join Date
    Mar 2007
    Location
    Austin, Texas
    Posts
    227
    Vote Rating
    1
    simeon is on a distinguished road

      0  

    Default


    Can you tell me which file changed to fix this issue?
    Having trouble finding it in the nightly

  4. #4
    Sencha - Support Team scottmartin's Avatar
    Join Date
    Jul 2010
    Location
    Houston, Tx
    Posts
    8,990
    Vote Rating
    455
    scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future scottmartin has a brilliant future

      0  

    Default


    Actually I did not dig through the PR's to find the diff, but just checked the example and it was working.

  5. #5
    Ext JS Premium Member simeon's Avatar
    Join Date
    Mar 2007
    Location
    Austin, Texas
    Posts
    227
    Vote Rating
    1
    simeon is on a distinguished road

      0  

    Default


    The fix for anyone with the same issue.

    Code:
    Ext.define('Taco.overrides.grid.plugin.RowEditing', {
        override: 'Ext.grid.plugin.RowEditing',
    
        // this is a fix for 4.2.2  remove this method after 4.3
        onEnterKey: function () {        
            // need skip over the superclass of this override as its method is overriding the base class;
            this.superclass.onEnterKey.apply(this, arguments)
            
        }  
    });

Thread Participants: 1