1. #1
    Ext User
    Join Date
    Feb 2008
    Posts
    34
    Vote Rating
    0
    JP_ExtJS is on a distinguished road

      0  

    Default [2.0??][CLOSED] GridPanel row selection

    [2.0??][CLOSED] GridPanel row selection


    Hi,
    You have a GridPanel with an Ext.grid.RowSelectionModel (the default), for example that in array-grid.js. If you have a custom renderer for a column that adds styling (for instance encloses value within <b></b>), when using IE7 to view the page, double clicking on a cell in that column selects the text under mouse cursor. This doesn't happen in FireFox.
    Here's the array sample modified to show the problem:
    Code:
    /*
    * Ext JS Library 2.0.1
    * Copyright(c) 2006-2008, Ext JS, LLC.
    * licensing@extjs.com
    * 
    * http://extjs.com/license
    */
    Ext.onReady(function(){
    Ext.state.Manager.setProvider(new Ext.state.CookieProvider());
    var myData = [
    ['3m Co',71.72,0.02,0.03,'9/1 12:00am'],
    ['Alcoa Inc',29.01,0.42,1.47,'9/1 12:00am'],
    ['Altria Group Inc',83.81,0.28,0.34,'9/1 12:00am'],
    ['American Express Company',52.55,0.01,0.02,'9/1 12:00am'],
    ['American International Group, Inc.',64.13,0.31,0.49,'9/1 12:00am'],
    ['AT&T Inc.',31.61,-0.48,-1.54,'9/1 12:00am'],
    ['Boeing Co.',75.43,0.53,0.71,'9/1 12:00am'],
    ['Caterpillar Inc.',67.27,0.92,1.39,'9/1 12:00am'],
    ['Citigroup, Inc.',49.37,0.02,0.04,'9/1 12:00am'],
    ['E.I. du Pont de Nemours and Company',40.48,0.51,1.28,'9/1 12:00am'],
    ['Exxon Mobil Corp',68.1,-0.43,-0.64,'9/1 12:00am'],
    ['General Electric Company',34.14,-0.08,-0.23,'9/1 12:00am'],
    ['General Motors Corporation',30.27,1.09,3.74,'9/1 12:00am'],
    ['Hewlett-Packard Co.',36.53,-0.03,-0.08,'9/1 12:00am'],
    ['Honeywell Intl Inc',38.77,0.05,0.13,'9/1 12:00am'],
    ['Intel Corporation',19.88,0.31,1.58,'9/1 12:00am'],
    ['International Business Machines',81.41,0.44,0.54,'9/1 12:00am'],
    ['Johnson & Johnson',64.72,0.06,0.09,'9/1 12:00am'],
    ['JP Morgan & Chase & Co',45.73,0.07,0.15,'9/1 12:00am'],
    ['McDonald\'s Corporation',36.76,0.86,2.40,'9/1 12:00am'],
    ['Merck & Co., Inc.',40.96,0.41,1.01,'9/1 12:00am'],
    ['Microsoft Corporation',25.84,0.14,0.54,'9/1 12:00am'],
    ['Pfizer Inc',27.96,0.4,1.45,'9/1 12:00am'],
    ['The Coca-Cola Company',45.07,0.26,0.58,'9/1 12:00am'],
    ['The Home Depot, Inc.',34.64,0.35,1.02,'9/1 12:00am'],
    ['The Procter & Gamble Company',61.91,0.01,0.02,'9/1 12:00am'],
    ['United Technologies Corporation',63.26,0.55,0.88,'9/1 12:00am'],
    ['Verizon Communications',35.57,0.39,1.11,'9/1 12:00am'],
    ['Wal-Mart Stores, Inc.',45.45,0.73,1.63,'9/1 12:00am']
    ];
    // example of custom renderer function
    function change(val){
    if(val > 0){
    return'<span style="color:green;">' + val + '</span>';
    }elseif(val < 0){
    return'<span style="color:red;">' + val + '</span>';
    }
    return val;
    }
    // example of custom renderer function
    function pctChange(val){
    if(val > 0){
    return'<span style="color:green;">' + val + '%</span>';
    }elseif(val < 0){
    return'<span style="color:red;">' + val + '%</span>';
    }
    return val;
    }
    // create the data store
    var store = new Ext.data.SimpleStore({
    fields: [
    {name: 'company'},
    {name: 'price', type: 'float'},
    {name: 'change', type: 'float'},
    {name: 'pctChange', type: 'float'},
    {name: 'lastChange', type: 'date', dateFormat: 'n/j h:ia'}
    ]
    });
    store.loadData(myData);
     
    //OUR CUSTOM RENDERER
    function myRenderer( value )
    {
    return"<b>" + value + "</b";
    //return value;
    }
    // create the Grid
    var grid = new Ext.grid.GridPanel({
    store: store,
    columns: [
    {id:'company',header: "Company", width: 160, sortable: true, dataIndex: 'company', renderer: myRenderer}, //<----HERE USE CUSTOM RENDERER (the rest of the file is the same)
    {header: "Price", width: 75, sortable: true, renderer: 'usMoney', dataIndex: 'price'},
    {header: "Change", width: 75, sortable: true, renderer: change, dataIndex: 'change'},
    {header: "% Change", width: 75, sortable: true, renderer: pctChange, dataIndex: 'pctChange'},
    {header: "Last Updated", width: 85, sortable: true, renderer: Ext.util.Format.dateRenderer('m/d/Y'), dataIndex: 'lastChange'}
    ],
    stripeRows: true,
    autoExpandColumn: 'company',
    height:350,
    width:600,
    title:'Array Grid'
    });
    grid.render('grid-example');
    grid.getSelectionModel().selectFirstRow();
    });

  2. #2
    Ext User
    Join Date
    Jul 2007
    Location
    Florida
    Posts
    9,996
    Vote Rating
    5
    mjlecomte will become famous soon enough mjlecomte will become famous soon enough

      0  

    Default


    I didn't test. Please confirm your malformed html isn't causing problems:

    PHP Code:
    return"<b>" value "</b";//missing closing '>' 

  3. #3
    Ext User
    Join Date
    Feb 2008
    Posts
    34
    Vote Rating
    0
    JP_ExtJS is on a distinguished road

      0  

    Default


    I confirm.
    Corrected code (bug still showing) -and you have to dbl-click on actual text in the cell:

    Code:
    /*
    * Ext JS Library 2.0.1
    * Copyright(c) 2006-2008, Ext JS, LLC.
    * licensing@extjs.com
    * 
    * http://extjs.com/license
    */
    Ext.onReady(function(){
    Ext.state.Manager.setProvider(new Ext.state.CookieProvider());
    var myData = [
    ['3m Co',71.72,0.02,0.03,'9/1 12:00am'],
    ['Alcoa Inc',29.01,0.42,1.47,'9/1 12:00am'],
    ['Altria Group Inc',83.81,0.28,0.34,'9/1 12:00am'],
    ['American Express Company',52.55,0.01,0.02,'9/1 12:00am'],
    ['American International Group, Inc.',64.13,0.31,0.49,'9/1 12:00am'],
    ['AT&T Inc.',31.61,-0.48,-1.54,'9/1 12:00am'],
    ['Boeing Co.',75.43,0.53,0.71,'9/1 12:00am'],
    ['Caterpillar Inc.',67.27,0.92,1.39,'9/1 12:00am'],
    ['Citigroup, Inc.',49.37,0.02,0.04,'9/1 12:00am'],
    ['E.I. du Pont de Nemours and Company',40.48,0.51,1.28,'9/1 12:00am'],
    ['Exxon Mobil Corp',68.1,-0.43,-0.64,'9/1 12:00am'],
    ['General Electric Company',34.14,-0.08,-0.23,'9/1 12:00am'],
    ['General Motors Corporation',30.27,1.09,3.74,'9/1 12:00am'],
    ['Hewlett-Packard Co.',36.53,-0.03,-0.08,'9/1 12:00am'],
    ['Honeywell Intl Inc',38.77,0.05,0.13,'9/1 12:00am'],
    ['Intel Corporation',19.88,0.31,1.58,'9/1 12:00am'],
    ['International Business Machines',81.41,0.44,0.54,'9/1 12:00am'],
    ['Johnson & Johnson',64.72,0.06,0.09,'9/1 12:00am'],
    ['JP Morgan & Chase & Co',45.73,0.07,0.15,'9/1 12:00am'],
    ['McDonald\'s Corporation',36.76,0.86,2.40,'9/1 12:00am'],
    ['Merck & Co., Inc.',40.96,0.41,1.01,'9/1 12:00am'],
    ['Microsoft Corporation',25.84,0.14,0.54,'9/1 12:00am'],
    ['Pfizer Inc',27.96,0.4,1.45,'9/1 12:00am'],
    ['The Coca-Cola Company',45.07,0.26,0.58,'9/1 12:00am'],
    ['The Home Depot, Inc.',34.64,0.35,1.02,'9/1 12:00am'],
    ['The Procter & Gamble Company',61.91,0.01,0.02,'9/1 12:00am'],
    ['United Technologies Corporation',63.26,0.55,0.88,'9/1 12:00am'],
    ['Verizon Communications',35.57,0.39,1.11,'9/1 12:00am'],
    ['Wal-Mart Stores, Inc.',45.45,0.73,1.63,'9/1 12:00am']
    ];
    // example of custom renderer function
    function change(val){
    if(val > 0){
    return'<span style="color:green;">' + val + '</span>';
    }elseif(val < 0){
    return'<span style="color:red;">' + val + '</span>';
    }
    return val;
    }
    // example of custom renderer function
    function pctChange(val){
    if(val > 0){
    return'<span style="color:green;">' + val + '%</span>';
    }elseif(val < 0){
    return'<span style="color:red;">' + val + '%</span>';
    }
    return val;
    }
    // create the data store
    var store = new Ext.data.SimpleStore({
    fields: [
    {name: 'company'},
    {name: 'price', type: 'float'},
    {name: 'change', type: 'float'},
    {name: 'pctChange', type: 'float'},
    {name: 'lastChange', type: 'date', dateFormat: 'n/j h:ia'}
    ]
    });
    store.loadData(myData);
     
    //OUR CUSTOM RENDERER
    function myRenderer( value )
    {
    return"<b>" + value + "</b>";
    //return value;
    }
    // create the Grid
    var grid = new Ext.grid.GridPanel({
    store: store,
    columns: [
    {id:'company',header: "Company", width: 160, sortable: true, dataIndex: 'company', renderer: myRenderer }, //<----HERE USE CUSTOM RENDERER (the rest of the file is the same) }
    {header: "Price", width: 75, sortable: true, renderer: 'usMoney', dataIndex: 'price'},
    {header: "Change", width: 75, sortable: true, renderer: change, dataIndex: 'change'},
    {header: "% Change", width: 75, sortable: true, renderer: pctChange, dataIndex: 'pctChange'},
    {header: "Last Updated", width: 85, sortable: true, renderer: Ext.util.Format.dateRenderer('m/d/Y'), dataIndex: 'lastChange'}
    ],
    stripeRows: true,
    autoExpandColumn: 'company',
    height:350,
    width:600,
    title:'Array Grid'
    });
    grid.render('grid-example');
    grid.getSelectionModel().selectFirstRow();
    });

  4. #4
    Sencha User jack.slocum's Avatar
    Join Date
    Mar 2007
    Location
    Tampa, FL
    Posts
    6,955
    Vote Rating
    17
    jack.slocum will become famous soon enough jack.slocum will become famous soon enough

      0  

    Default


    You didn't turn off IE text selection in the element you added.

    e.g.

    <b unselectable="on">my stuff</b>

    Please post in help before bugs. Thanks.
    Jack Slocum
    Ext JS Founder
    Original author of Ext JS 1, 2 & 3.
    Twitter: @jackslocum
    jack@extjs.com

  5. #5
    Ext User
    Join Date
    Feb 2008
    Posts
    34
    Vote Rating
    0
    JP_ExtJS is on a distinguished road

      0  

    Default


    Thanks.

Thread Participants: 2