1. #1
    Ext User ushkinaz's Avatar
    Join Date
    Apr 2008
    Posts
    25
    Vote Rating
    0
    ushkinaz is on a distinguished road

      0  

    Default [FIXED] 0.5.x RowSelection model bug and patch

    [FIXED] 0.5.x RowSelection model bug and patch


    Since net.mygwt.ui.client.viewer.TableViewer#setSelection(ISelection, boolean) uses fairly ineffective approach and selects/deselects every item in a table, there is enormous amounts of SelectionChange events fired even for simple cases.
    For instance, if none is selected and I call setSelection(new DefaultSelection()) on a table with 100 rows, 100 SelectionChange events will be generated.

    One possible way to fix is in attached patch.
    It also fixes a little problem with render listener.
    Attached Files

  2. #2
    Sencha - GXT Dev Team darrellmeyer's Avatar
    Join Date
    May 2007
    Location
    Washington, DC
    Posts
    2,242
    Vote Rating
    2
    darrellmeyer is on a distinguished road

      0  

    Default


    The Table and TableViewer selection code need to be refactored which I am doing now. Changes will go out in the next rev.

  3. #3
    Ext User ushkinaz's Avatar
    Join Date
    Apr 2008
    Posts
    25
    Vote Rating
    0
    ushkinaz is on a distinguished road

      0  

    Default


    Will in include fix for vertical lines? (i have my fingers crossed)

  4. #4
    Ext User ushkinaz's Avatar
    Join Date
    Apr 2008
    Posts
    25
    Vote Rating
    0
    ushkinaz is on a distinguished road

      0  

    Default


    One more thing.

    Consider following scenarion:

    1. I have a list with 10 elements.
    2. I'm programmatically selecting 10 of them at once.
    3. I'm getting 10 SelectionChange events.

    I'd like to have only one event in this case. Same for deselecting, of course. Also adding/removing.

  5. #5
    Sencha - GXT Dev Team darrellmeyer's Avatar
    Join Date
    May 2007
    Location
    Washington, DC
    Posts
    2,242
    Vote Rating
    2
    darrellmeyer is on a distinguished road

      0  

    Default


    Yes, this is part of the reason I am changing the code.

  6. #6
    Sencha - GXT Dev Team darrellmeyer's Avatar
    Join Date
    May 2007
    Location
    Washington, DC
    Posts
    2,242
    Vote Rating
    2
    darrellmeyer is on a distinguished road

      0  

    Default


    This is fixed in beta2. Please validate.

  7. #7
    Ext User ushkinaz's Avatar
    Join Date
    Apr 2008
    Posts
    25
    Vote Rating
    0
    ushkinaz is on a distinguished road

      0  

    Default


    thx, but I'm not able to validate anything 1.x related

Thread Participants: 1