1. #1
    Sencha - Ext JS Dev Team evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    16,648
    Vote Rating
    583
    evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute

      0  

    Default Post editing completely broken

    Post editing completely broken


    Since the forum upgrade, there was a bug with editing posts. The changes took effect, however the page didn't refresh.

    Now, I can't edit posts at all, running on FF2.

    Can you have a look please?

  2. #2
    Sencha User jack.slocum's Avatar
    Join Date
    Mar 2007
    Location
    Tampa, FL
    Posts
    6,955
    Vote Rating
    16
    jack.slocum will become famous soon enough

      0  

    Default


    I looked at it but I don't have a clue. Any vBulletin experts out there with any ideas?
    Jack Slocum
    Ext JS Founder
    Original author of Ext JS 1, 2 & 3.
    Twitter: @jackslocum
    jack@extjs.com

  3. #3
    Sencha - Community Support Team hendricd's Avatar
    Join Date
    Aug 2007
    Location
    Long Island, NY USA
    Posts
    5,962
    Vote Rating
    10
    hendricd will become famous soon enough hendricd will become famous soon enough

      0  

    Default


    Switching to Advanced for editing works fine tho.
    "be dom-ready..."
    Doug Hendricks

    Maintaining ux: ManagedIFrame, MIF2 (FAQ, Wiki), ux.Media/Flash, AudioEvents, ux.Chart[Fusion,OFC,amChart], ext-basex.js/$JIT, Documentation Site.


    Got Sencha licensing questions? Find out more here.


  4. #4
    Ext User
    Join Date
    May 2007
    Posts
    77
    Vote Rating
    0
    antimatter15 is on a distinguished road

      0  

    Default


    I did a quick search, and http://www.vbulletin.com/forum/proje...?issueid=22912 is the same problem, but it's an issue with prototype.js.

  5. #5
    Sencha User
    Join Date
    Jan 2008
    Posts
    240
    Vote Rating
    0
    OutpostMM is on a distinguished road

      0  

    Default


    I see the same thing with Opera, I just refresh the page after editing the post.

  6. #6
    Sencha - Community Support Team mystix's Avatar
    Join Date
    Mar 2007
    Location
    Singapore
    Posts
    6,236
    Vote Rating
    5
    mystix will become famous soon enough

      0  

    Default


    Firebug to the rescue...

    when cancelling a quickedit:



    when saving a quickedit:


    i tried to dive through vB's scripts, but they're ugly.
    i couldn't stand the ugliness.

  7. #7
    Ext JS Premium Member dj's Avatar
    Join Date
    Mar 2007
    Location
    Germany
    Posts
    573
    Vote Rating
    2
    dj has a spectacular aura about dj has a spectacular aura about dj has a spectacular aura about

      0  

    Default


    vBulletin uses JavaScript Array objects as hashes and iterates over them by
    Code:
    for (var i in array) {
      // do something with array[i]
    }
    that doesn't work with Ext Js because Ext Js adds several functions to the Array prototype.

    To fix this error, one has to change all hashes to Objects and/or all for-loops to skip prototype-properties
    Code:
    for (var i in array) {
      if (array.hasOwnProperty(i)){
        // do something with array[i]
      }
    }

    I just did a quick scan of the sources and found quite some of these for-loops that need to be adjusted. Just regex-search for "for\s*\(.*\sin\s.*\)" to find these.

    Edit on Safari ... also works after a refresh
    Daniel Jagszent
    dɐɳiel@ʝɐgszeɳt.de <- convert to plain ASCII to get my email address

  8. #8
    Sencha User jack.slocum's Avatar
    Join Date
    Mar 2007
    Location
    Tampa, FL
    Posts
    6,955
    Vote Rating
    16
    jack.slocum will become famous soon enough

      0  

    Default


    Thanks mystix and dj. It should be fixed now (may require refresh).

    Edit: (Does this edit work???)

    Edit: Yes it does!
    Jack Slocum
    Ext JS Founder
    Original author of Ext JS 1, 2 & 3.
    Twitter: @jackslocum
    jack@extjs.com

  9. #9
    Ext JS Premium Member dj's Avatar
    Join Date
    Mar 2007
    Location
    Germany
    Posts
    573
    Vote Rating
    2
    dj has a spectacular aura about dj has a spectacular aura about dj has a spectacular aura about

      0  

    Default


    The font and font-size lists also needs this patch
    Daniel Jagszent
    dɐɳiel@ʝɐgszeɳt.de <- convert to plain ASCII to get my email address

  10. #10
    Sencha - Community Support Team mystix's Avatar
    Join Date
    Mar 2007
    Location
    Singapore
    Posts
    6,236
    Vote Rating
    5
    mystix will become famous soon enough

      0  

    Default


    Quote Originally Posted by jack.slocum View Post
    Thanks mystix and dj. It should be fixed now (may require refresh).

    Edit: (Does this edit work???)

    Edit: Yes it does!
    thanks!

    p.s. [code][/code] tag styles seem to have changed -- long code lines now wrap instead of continuing on forever.