1. #1
    Banned
    Join Date
    Mar 2007
    Posts
    57
    Vote Rating
    0
    buzz is on a distinguished road

      0  

    Default GXT Beta3: EPL classes still present

    GXT Beta3: EPL classes still present


    Darrell,
    Just got back from vacation and noticed that Beta 3 is finally out. Great.
    I have noticed that there are still some EPL licensed classes in the Beta 3 release. When are you planning on removing them.
    Please tell me that I don't have to wait another 3 weeks for beta 4

  2. #2
    Sencha User
    Join Date
    Jan 2008
    Posts
    55
    Vote Rating
    0
    skhan is on a distinguished road

      0  

    Default


    Can you list the classes you think fall under the EPL licence?
    I had a look through the classes and I couldn't find any.

  3. #3
    Sencha - GXT Dev Team darrellmeyer's Avatar
    Join Date
    May 2007
    Location
    Washington, DC
    Posts
    2,242
    Vote Rating
    2
    darrellmeyer is on a distinguished road

      0  

    Default


    As skhan stated, there are no EPL classes in beta 3. What classes are you referring to?

  4. #4
    Banned
    Join Date
    Mar 2007
    Posts
    57
    Vote Rating
    0
    buzz is on a distinguished road

      0  

    Default


    I haven't gone through all the classes (I'll leave that you ), but here are 4 classes that I found

    com.extjs.gxt.client.util.Rectangle
    com.extjs.gxt.client.widget.layout.FillLayout
    com.extjs.gxt.client.widget.layout.RowLayout
    com.extjs.gxt.client.widget.layout.RowData

    From Beta 2 license
    "SWT
    The following classes in the GXT JAR are based on SWT code
    developed by the Eclipse Foundation and shall be defined as the
    "SWT-Derived Work":

    com.extjs.gxt.client.Style
    com.extjs.gxt.client.event.TypedListener
    com.extjs.gxt.client.util.EventTable
    com.extjs.gxt.client.util.Rectangle
    com.extjs.gxt.client.widget.layout.FillLayout
    com.extjs.gxt.client.widget.layout.RowLayout
    com.extjs.gxt.client.widget.layout.RowData

    Your use of the SWT-Derived Work is subject to the terms and
    conditions of the Eclipse Public License v1.0. A copy of the license
    is contained in the file license/epl-v10.html and is also available at
    http://www.eclipse.org/legal/epl-v10.html."

  5. #5
    Ext GWT Premium Member gslender's Avatar
    Join Date
    Mar 2008
    Location
    Brisbane, Australia
    Posts
    1,572
    Vote Rating
    3
    gslender is on a distinguished road

      0  

    Default


    In beta3 there isn't any use of the EPL license so I guess there is no problem.

    I wonder if you are trying to suggest copyright infringement?

    I'm not sure how copyright law works in the USA, but over here in the land of Oz, you can't lay claim to basic concepts, like a rectangle, laying out things by fill or flow etc... there is only so many ways you can define things around these simple concepts - as such that wouldn't be copyright.

    Just because someone slaps a license/copyright message on something doesn't mean they have the right or ability to legally enforce it.

    BTW - this is just my view on the situation - ExtJS should get their own legal advice though

  6. #6
    Sencha - GXT Dev Team darrellmeyer's Avatar
    Join Date
    May 2007
    Location
    Washington, DC
    Posts
    2,242
    Vote Rating
    2
    darrellmeyer is on a distinguished road

      0  

    Default


    Some of the class names are the same as the SWT classes. However, if you look at the code and API of any of the classes you mentioned, you will see that the classes are completely different from the SWT classes.

    Every EPL class was updated with the removal of the EPL code to ensure no SWT based code was in GXT. For example, EventTable was completely rewritten. Previously, the class used some of the code from SWT EventTable. The code was changed, the class names were not.

    If you still have any doubts or concerns on this issue, feel free to contact us.

  7. #7
    Banned
    Join Date
    Mar 2007
    Posts
    57
    Vote Rating
    0
    buzz is on a distinguished road

      0  

    Default


    Some of the class names are the same as the SWT classes. However, if you look at the code and API of any of the classes you mentioned, you will see that the classes are completely different from the SWT classes.

    Every EPL class was updated with the removal of the EPL code to ensure no SWT based code was in GXT. For example, EventTable was completely rewritten. Previously, the class used some of the code from SWT EventTable. The code was changed, the class names were not.
    Darell,
    I'm not talking about EventTable. I had mentioned the classes

    com.extjs.gxt.client.util.Rectangle
    com.extjs.gxt.client.widget.layout.FillLayout
    com.extjs.gxt.client.widget.layout.RowLayout
    com.extjs.gxt.client.widget.layout.RowData

    And since you got me curious, I just did a diff between ExtGWT beta2 and beta3 for the above classes and the big difference I see is that you've replaced the header from

    Code:
    /*******************************************************************************
     * Copyright (c) 2000, 2007 IBM Corporation and others.
     * All rights reserved. This program and the accompanying materials
     * are made available under the terms of the Eclipse Public License v1.0
     * which accompanies this distribution, and is available at
     * http://www.eclipse.org/legal/epl-v10.html
     *
     * Contributors:
     *     IBM Corporation - initial API and implementation
     *     Ext GWT - derived implementation
     *******************************************************************************/
    to

    Code:
    /*
     * Ext GWT - Ext for GWT
     * Copyright(c) 2007, 2008, Ext JS, LLC.
     * licensing@extjs.com
     *
     * http://extjs.com/license
     */
    The code is pretty much the same for all these classes besides some javadoc and variable name alterations and removing the original EPL attribution doesn't seem right

    gslender - not all users are from Australia and I personally don't care about Australian laws

  8. #8
    Sencha - GXT Dev Team darrellmeyer's Avatar
    Join Date
    May 2007
    Location
    Washington, DC
    Posts
    2,242
    Vote Rating
    2
    darrellmeyer is on a distinguished road

      0  

    Default


    I reviewed the classes you listed and only FillLayout contained any code from the corresponding SWT class. Nonetheless, I have made the following changes.

    Rectangle
    A rectangle is a rectangle. The Rectangle API is identical to the Java Rectangle class. There should not be any issues here.

    RowLayout / RowData
    RowLayout has been completely rewritten. The new changes:

    1. Children are no longer positioned using absolute positioning. This is a much better design with better performance.
    2. Margins and spacing use CSS padding and margins. The old code applied spacing and margins to the positioning and sizing of child components.
    3. Removed the "fill" feature from RowData. Each child component can specify its height and width in pixels or as a percentage. More than 1 child can use percentage values.

    FillLayout
    FillLayout now extends RowLayout and has been rewritten.

    RowLayout and FillLayout are not used in the GXT core code because of the use of absolute positioning. With these changes, the layouts are more inline with the other GXT layouts.

    The code is pretty much the same for all these classes besides some javadoc and variable name alterations and removing the original EPL attribution doesn't seem right
    With the new changes, there is no use of EPL code. The changes are in SVN.

    I am attaching the GXT and SWT classes for RowLayout, RowData, and FillLayout. Let us know if you still have any concerns.
    Attached Files

  9. #9
    Banned
    Join Date
    Mar 2007
    Posts
    57
    Vote Rating
    0
    buzz is on a distinguished road

      0  

    Default


    Thanks but this gives me little comfort. During the beta3 refactor in an attempt to remove the EPL dependencies we're you not aware that you were violating the SWT license when you changed the header that indicated that the code was derived from EPL to the Ext license header? And also when I initially pointed out the issues, you confidently mentioned that there is no SWT code. I hope it wasn't the intent that this went undiscovered. Anyway I am not a premium member and therefore don't have SVN access. I'll look at it when beta 4 comes out and hope that beta4 actually had no other license violation(s).

  10. #10
    Sencha - GXT Dev Team darrellmeyer's Avatar
    Join Date
    May 2007
    Location
    Washington, DC
    Posts
    2,242
    Vote Rating
    2
    darrellmeyer is on a distinguished road

      0  

    Default


    Beta 4 is now available.

Turkiyenin en sevilen filmlerinin yer aldigi xnxx internet sitemiz olan ve porn sex tarzi bir site olan mobil porno izle sitemiz gercekten dillere destan bir durumda herkesin sevdigi bir site olarak tarihe gececege benziyor. Sitenin en belirgin ozelliklerinden birisi de Turkiyede gercekten kaliteli ve muntazam, duzenli porno izle siteleri olmamasidir. Bu yuzden iste. Ayrica en net goruntu kalitesine sahip adresinde yayinlanmaktadir. Mesela diğer sitelerimizden bahsedecek olursak, en iyi hd porno video arşivine sahip bir siteyiz. "The Best anal porn videos and slut anus, big asses movies set..."