Feature Request: Closeable TabItem with possibility to abort closing

[jraue]

Hi,

I would like to implement a closeable TabItem that asks a confirmation message when the close button is clicked and aborts the closing if the user does not confirm.

IMHO, this would be possible if TabPanel could be expanded a bit at line 740, currently:

void onItemClick(TabItem item, ComponentEvent ce) {
ce.stopEvent();
Element target = ce.getTarget();
if (fly(target).getStyleName().equals("x-tab-strip-close")) {
remove(item);
item.fireEvent(Events.Close, new TabPanelEvent(this, item));
return;
} else if (item != activeItem) {
setSelection(item);
}
}

It should fire an Events.BeforeClose event and conditionally execute the remove item. Should be realizable in a few minutes and would help me a great deal.

Thanks,

Joachim

[gslender]

TabPanel does support

    BeforeRemove : TabPanelEvent(tabPanel, item)
    Fires before a item is removed. Listeners can set the doit field to false to cancel the action.

        * tabPanel : this
        * item : the item being removed

does that not work as expected?

[darrellmeyer]

TabItem now fires a BeforeClose event which can be canceled. Also, TabPanel was updated so that BeforeRemove is fired before the item has been closed.

Fixes are in SVN.

[jraue]

Thanks a lot, guys!