1. #1
    Ext User
    Join Date
    Mar 2007
    Posts
    2
    Vote Rating
    0
    redbulljunkie is on a distinguished road

      0  

    Default CompositeElement.add Error ??

    CompositeElement.add Error ??


    Hi there,

    First time poster ( feels like I'm on a radio show )

    First off, just wanted to say a BIG thank you to Mr. Jack Slocum for creating this fantastic library. It has re-ignited my passion for programming and learning.

    I know there have been a few people complaining that the documentation is not complete and out of date but to me there is actually no better way to understand how something works than actually going through the source and figuring it out for yourself.

    Which is how I came across this section of code inside of CompositeElement.js

    Code:
    add : function(els){
        if(typeof els == "string"){
            this.addElements(Ext.Element.selectorFunction(string));
        }else if(els.length !== undefined){
            this.addElements(els);
        }else{
            this.addElements([els]);
        }
    return this;
    },
    I'm sure this is a bug as string is undefined and it should be passing els instead.

    Not sure if this has already been reported, hope it helps.

    Again, a HUGE thank you for providing the world with a first class library.

    Tony

  2. #2
    Sencha User jack.slocum's Avatar
    Join Date
    Mar 2007
    Location
    Tampa, FL
    Posts
    6,955
    Vote Rating
    17
    jack.slocum will become famous soon enough jack.slocum will become famous soon enough

      0  

    Default


    I should have been drinking redbull when I coded that.

    Thanks!
    Jack Slocum
    Ext JS Founder
    Original author of Ext JS 1, 2 & 3.
    Twitter: @jackslocum
    jack@extjs.com

Thread Participants: 1