[2.1][DUP][OPEN] Combo forceSelection,allowBlank,emptyText & lastSelectionText

[veroxii]

you can add an else with the if ,to set the value of combobox to null

Yes, but your code references the object by name...

The proper clean way to override the function, and which works fine for me is the following:

Ext.override(Ext.form.ComboBox, {
    // private
    doForce : function() {
        if (this.el.dom.value != this.emptyText && this.el.dom.value.length > 0) {
            this.el.dom.value = this.lastSelectionText === undefined? '' : this.lastSelectionText;
            this.applyEmptyText();
        } else {
            this.clearValue();
        }
    }    
});

-V

[george4kenco]

This override:
1) did not work for me, the value is still being set back to empty text
2) at least from reading the code, the above seems like what this override would do. I mean, semantically there does not seem to be a lot of difference between applyEmptyText() and clearValue(). Semantics aside, its obvious that the first condition does not retain the value of "this.el.dom.value"

Yes, but your code references the object by name...

The proper clean way to override the function, and which works fine for me is the following:

Ext.override(Ext.form.ComboBox, {
    // private
    doForce : function() {
        if (this.el.dom.value != this.emptyText && this.el.dom.value.length > 0) {
            this.el.dom.value = this.lastSelectionText === undefined? '' : this.lastSelectionText;
            this.applyEmptyText();
        } else {
            this.clearValue();
        }
    }    
});

-V

[george4kenco]

Without delving into the arcana surrounding lastSelectionText because, after all, I'm trying to write a business application here, as opposed to a Javascript framework, isn't the following what is actually correct, retaining the value of this.el.dom.value as appropriate?

Ext.override(Ext.form.ComboBox, {
    // private
    doForce : function() {
        if (this.el.dom.value != this.emptyText && this.el.dom.value.length > 0) {
            this.el.dom.value = this.lastSelectionText === undefined? this.el.dom.value : this.lastSelectionText;
            this.applyEmptyText();
        } else {
            this.clearValue();
        }
    }
});

[george4kenco]

Damn I guess I have to delve into lastSelectionText because thinking about it, this would actually seem to revert to the behavior that forceSelection is trying to prevent. Problem is, in my case, lastSelectionText is coming through as undefined

Supreme WTFY

Without delving into the arcana surrounding lastSelectionText because, after all, I'm trying to write a business application here, as opposed to a Javascript framework, isn't the following what is actually correct, retaining the value of this.el.dom.value as appropriate?

Ext.override(Ext.form.ComboBox, {
    // private
    doForce : function() {
        if (this.el.dom.value != this.emptyText && this.el.dom.value.length > 0) {
            this.el.dom.value = this.lastSelectionText === undefined? this.el.dom.value : this.lastSelectionText;
            this.applyEmptyText();
        } else {
            this.clearValue();
        }
    }
});

[george4kenco]

As it turns out, the supreme wtfy is on our end, we are overriding onSelect in such a way that setValue is not getting called, which in turn sets lastSelectionText; since its not getting set, my combobox never retains its value.

Damn I guess I have to delve into lastSelectionText because thinking about it, this would actually seem to revert to the behavior that forceSelection is trying to prevent. Problem is, in my case, lastSelectionText is coming through as undefined

Supreme WTFY

[george4kenco]

So what I'm now doing at the top of our override is the following, it may not be ideal, but it has a similar effect to the call to setValue in onSelect (when the latter is not overridden):

this.lastSelectionText=record.data[this.valueField || this.displayField];

Additionally, apologies the attitude

As it turns out, the supreme wtfy is on our end, we are overriding onSelect in such a way that setValue is not getting called, which in turn sets lastSelectionText; since its not getting set, my combobox never retains its value.

[mystix]

So what I'm now doing at the top of our override is the following, it may not be ideal, but it has a similar effect to the call to setValue in onSelect (when the latter is not overridden):

this.lastSelectionText=record.data[this.valueField || this.displayField];

Additionally, apologies the attitude

are you still on 2.1, or have you upgraded to 2.3.0?

[george4kenco]

are you still on 2.1, or have you upgraded to 2.3.0?

2.2 actually

[mystix]

2.2 actually

hmmm... you might want to bite the bullet and try 2.3.0.
there's been a ton (quite literally) of fixes between 2.2 and 2.3.0, and i think this might just be one of them.