1. #1
    Sencha - Community Support Team SamuraiJack1's Avatar
    Join Date
    May 2008
    Posts
    558
    Vote Rating
    3
    SamuraiJack1 will become famous soon enough

      0  

    Default [2.2] fit layout bug

    [2.2] fit layout bug


    Fit layout is totally unaware about its own paddings and its child margins:

    Code:
                Ext.onReady(function(){
    
                    var p = new Ext.Window({
                        width : 500,
                        height: 300,
                        layout : 'fit',
                        items : [{
                            style : 'margin: 50px;'
                        }] 
                    });
                    
                    p.show();
                });

  2. #2
    Sencha - Ext JS Dev Team Animal's Avatar
    Join Date
    Mar 2007
    Location
    Notts/Redwood City
    Posts
    30,544
    Vote Rating
    64
    Animal is a jewel in the rough Animal is a jewel in the rough Animal is a jewel in the rough

      0  

    Default


    The problem of accounting for the Container Element's padding and child item Element's margins exists in several layouts. It needs fully investigating by the core devs.

  3. #3
    Sencha - Community Support Team SamuraiJack1's Avatar
    Join Date
    May 2008
    Posts
    558
    Vote Rating
    3
    SamuraiJack1 will become famous soon enough

      0  

    Default


    Yeah, seems almost all layouts affected, except Column (which have another strange behavior - different height columns).

  4. #4
    Sencha - Ext JS Dev Team Animal's Avatar
    Join Date
    Mar 2007
    Location
    Notts/Redwood City
    Posts
    30,544
    Vote Rating
    64
    Animal is a jewel in the rough Animal is a jewel in the rough Animal is a jewel in the rough

      0  

    Default


    I have posted a fix for that: http://extjs.com/forum/showthread.php?t=45143

  5. #5
    Sencha - Community Support Team SamuraiJack1's Avatar
    Join Date
    May 2008
    Posts
    558
    Vote Rating
    3
    SamuraiJack1 will become famous soon enough

      0  

    Default


    Quote Originally Posted by Animal View Post
    I have posted a fix for that: http://extjs.com/forum/showthread.php?t=45143
    I also patched it (for personal use). As I saw there is also Saki's patch for this.

    So the problem is solved 3 times and actually it is still not solved - quantum effect ).

    As I see the problem is that Ext is almost "closed source" for now - there are no chances to apply patch for this to development trunk for example.

  6. #6
    Sencha - Ext JS Dev Team Animal's Avatar
    Join Date
    Mar 2007
    Location
    Notts/Redwood City
    Posts
    30,544
    Vote Rating
    64
    Animal is a jewel in the rough Animal is a jewel in the rough Animal is a jewel in the rough

      0  

    Default


    I'm sure Jack and Brian have seen the questions and reports about layouts not taking into account the container element's padding, and the component elements' margins, and have plans to overhaul the layout manager classes.

  7. #7
    Sencha - Community Support Team SamuraiJack1's Avatar
    Join Date
    May 2008
    Posts
    558
    Vote Rating
    3
    SamuraiJack1 will become famous soon enough

      0  

    Default


    IMHO they should just implement patch applying culture in the community.

  8. #8
    Sencha - Ext JS Dev Team Animal's Avatar
    Join Date
    Mar 2007
    Location
    Notts/Redwood City
    Posts
    30,544
    Vote Rating
    64
    Animal is a jewel in the rough Animal is a jewel in the rough Animal is a jewel in the rough

      0  

    Default


    I think it would be disastrous to open up the SVN repository to anyone who wants to throw code in.

  9. #9
    Sencha - Community Support Team SamuraiJack1's Avatar
    Join Date
    May 2008
    Posts
    558
    Vote Rating
    3
    SamuraiJack1 will become famous soon enough

      0  

    Default


    Sure. I'm about "patch culture" like in any other open source project. If you wrote a patch and it looks sane - you have good chances it will be applied by authors (may be after discussing, refactoring, etc).

  10. #10
    Sencha - Ext JS Dev Team Animal's Avatar
    Join Date
    Mar 2007
    Location
    Notts/Redwood City
    Posts
    30,544
    Vote Rating
    64
    Animal is a jewel in the rough Animal is a jewel in the rough Animal is a jewel in the rough

      0  

    Default


    I think Jack and Brian do work like that. It just seems to have slowed up in the past 6 to 9 months.

    Before that you could feed code in, Jack would process it and come up with a version of it in just a couple of hours. I think they are very busy now, and with more responsibility on solid releases, the turnaround on code fixes gets longer and longer. It just cab't be as agile as when it was one man and his PC.

Thread Participants: 1