[2.2] fit layout bug

[SamuraiJack1]

Fit layout is totally unaware about its own paddings and its child margins:

            Ext.onReady(function(){

                var p = new Ext.Window({
                    width : 500,
                    height: 300,
                    layout : 'fit',
                    items : [{
                        style : 'margin: 50px;'
                    }] 
                });
                
                p.show();
            });

[Animal]

The problem of accounting for the Container Element's padding and child item Element's margins exists in several layouts. It needs fully investigating by the core devs.

[SamuraiJack1]

Yeah, seems almost all layouts affected, except Column (which have another strange behavior - different height columns).

[Animal]

I have posted a fix for that: http://extjs.com/forum/showthread.php?t=45143

[SamuraiJack1]

I have posted a fix for that: http://extjs.com/forum/showthread.php?t=45143

I also patched it (for personal use). As I saw there is also Saki's patch for this.

So the problem is solved 3 times and actually it is still not solved - quantum effect ).

As I see the problem is that Ext is almost "closed source" for now - there are no chances to apply patch for this to development trunk for example.

[Animal]

I'm sure Jack and Brian have seen the questions and reports about layouts not taking into account the container element's padding, and the component elements' margins, and have plans to overhaul the layout manager classes.

[SamuraiJack1]

IMHO they should just implement patch applying culture in the community.

[Animal]

I think it would be disastrous to open up the SVN repository to anyone who wants to throw code in.

[SamuraiJack1]

Sure. I'm about "patch culture" like in any other open source project. If you wrote a patch and it looks sane - you have good chances it will be applied by authors (may be after discussing, refactoring, etc).

[Animal]

I think Jack and Brian do work like that. It just seems to have slowed up in the past 6 to 9 months.

Before that you could feed code in, Jack would process it and come up with a version of it in just a couple of hours. I think they are very busy now, and with more responsibility on solid releases, the turnaround on code fixes gets longer and longer. It just cab't be as agile as when it was one man and his PC.