[FIXED][2.x] Ext.num(NaN, 0) returns NaN

[mystix]

the following code

Ext.num(NaN, 0);

returns NaN instead of zero. (yes, NaN is a number unfortunately).

i propose the following simple fix:

Ext.apply(
    num : function(v, defaultValue) {
        return Number(String(v))? Number(v) : defaultValue;
    }
});

which performs type string-to-number coercion where applicable (which imho should take place. i refer to one such help request: http://extjs.com/forum/showthread.php?t=46438).

[jack.slocum]

What about:

num : function(v, defaultValue){
            if(typeof v != 'number' || isNaN(v)){
                return defaultValue;
            }
            return v;
        }

[mystix]

that definitely works, but doesn't take care of the following valid numeric values, simply because they're quoted and hence of type String:

'1.9'
'-.9'
'+8.'

p.s. wasn't the intent of Ext.num() to address the shortcomings of js's isNaN() method
i.e. to check if a number could successfully be coerced into a numeric value, minus the quirks surrounding isNaN()?

[robw]

I just came across this issue trying:

Ext.num('1',0) //returns 0 

Expected it to return 1 (as a number). Would be great if it did the conversion - i guess it would have to decide on parseInt or parseFloat if isNaN returns false?

Thanks
Rob

[mystix]

I just came across this issue trying:

Ext.num('1',0) //returns 0 

Expected it to return 1 (as a number). Would be great if it did the conversion - i guess it would have to decide on parseInt or parseFloat if isNaN returns false?

Thanks
Rob

if it helps, here's what i'm currently using:

Ext.apply(Ext, {
    num : function(v, defaultValue) {
        v = Number(v); // cast value to type Number

        return !isNaN(v)? v : defaultValue;
    }
});

which takes care of everything i know of (including the 3 examples i posted above) -- no parseFloat / parseInt required.

[robw]

great thanks - I was overcomplicating it

[evant]

Modified in SVN.

[mystix]

found one more failing test case:

Ext.num(null); // returns 0

a tiny change is needed with the code in SVN to prevent this:

Ext.apply(Ext, {
    num : function(v, defaultValue) {
        v = Number(v == null? NaN : v);
        return !isNaN(v)? v : defaultValue;
    }
});

[evant]

Committed.