Adding/removing fields and columns

[wwwjsx]

Condor

thank you for your sharing code. I have problem when I using the colIndex it is not possible to touch the added column. I am trying manually switch off the added column.

see:
http://my.jetscreenshot.com/demo/20091130-guuz-1kb.jpg

If i use withour colIndex works very fine

[Condor]

I have problem when I using the colIndex it is not possible to touch the added column.

Are you sure you didn't configure the column with fixed:true or hideable:false?

Otherwise, can you post an example?

[asagala]

Trying to add a column as the first column in the grid by doing this

this.addColumn(0,'C'); -> this. is my grid

but it always adds it to the end. Anyone have a clue?

[asagala]

Nevermind misread the function parameters. Was using the one for the gridcolumn. The one for the grid should be this.addColumn('C','C',0);

[jsakalos]

i think this should be added to the base!

+1

[tobiu]

+1

[Izhaki]

Hi,

Firstly, thank Condor for this.

Then, +1 here as well, but before:

The provided code could break JsonReader/XmlReader calls since buildExtractors is not called. It's a bit odd since sometimes it works, other times it throws load exception or just doesn't load the values. This is due to this (JsonReader):

    extractValues : function(data, items, len) {
        var f, values = {};
        for(var j = 0; j < len; j++){
            f = items[j];
            var v = this.ef[j](data);
            values[f.name] = f.convert((v !== undefined) ? v : f.defaultValue, data);
        }
        return values;
    }

So my fix:

Ext.override(Ext.data.Store,{
  addField: function(field){
    field = new Ext.data.Field(field);
    this.recordType.prototype.fields.replace(field);
    if(typeof field.defaultValue != 'undefined'){
      this.each(function(r){
        if(typeof r.data[field.name] == 'undefined'){
          r.data[field.name] = field.defaultValue;
        }
      });
    }
    delete this.reader.ef;
    this.reader.buildExtractors();
  },
  removeField: function(name){
    this.recordType.prototype.fields.removeKey(name);
    this.each(function(r){
      delete r.data[name];
      if(r.modified){
        delete r.modified[name];
      }
    });
    delete this.reader.ef;
    this.reader.buildExtractors();
  }
});

Cheers

[Condor]

The provided code could break JsonReader/XmlReader calls since buildExtractors is not called. It's a bit odd since sometimes it works, other times it throws load exception or just doesn't load the values.

Wouldn't it be better to return metaData from the server? In that case the fields and the data are always in sync.

[Izhaki]

Sure,

metaData will solve this. But if this mod is to be added to the base, I thought I should report this issue/fix.

Also, it took me 4 hours to work out what's wrong, so to save the time for other people...

Cheers

[kamalhg]

this fix makes the extension works with 3.1.x

Hi,

Firstly, thank Condor for this.

Then, +1 here as well, but before:

The provided code could break JsonReader/XmlReader calls since buildExtractors is not called. It's a bit odd since sometimes it works, other times it throws load exception or just doesn't load the values. This is due to this (JsonReader):

    extractValues : function(data, items, len) {
        var f, values = {};
        for(var j = 0; j < len; j++){
            f = items[j];
            var v = this.ef[j](data);
            values[f.name] = f.convert((v !== undefined) ? v : f.defaultValue, data);
        }
        return values;
    }

So my fix:

Ext.override(Ext.data.Store,{
  addField: function(field){
    field = new Ext.data.Field(field);
    this.recordType.prototype.fields.replace(field);
    if(typeof field.defaultValue != 'undefined'){
      this.each(function(r){
        if(typeof r.data[field.name] == 'undefined'){
          r.data[field.name] = field.defaultValue;
        }
      });
    }
    delete this.reader.ef;
    this.reader.buildExtractors();
  },
  removeField: function(name){
    this.recordType.prototype.fields.removeKey(name);
    this.each(function(r){
      delete r.data[name];
      if(r.modified){
        delete r.modified[name];
      }
    });
    delete this.reader.ef;
    this.reader.buildExtractors();
  }
});

Cheers