1. #21
    Ext User Minnow's Avatar
    Join Date
    Mar 2008
    Posts
    17
    Vote Rating
    1
    Minnow is on a distinguished road

      0  

    Default Insert not rolled back

    Insert not rolled back


    Hey - cool toy.

    You need to insert the following at line 476

    case 'insertChild':

    so that it reads:

    PHP Code:
    if(true !== o.success) {
        
    this.showError(o.error || o.errors);
        switch(
    options.action) {
            case 
    'appendChild':
            case 
    'insertChild':
                
    options.node.parentNode.removeChild(options.node);
            break;
            default:
            break;
        }
        return;


  2. #22
    Sencha - Community Support Team jsakalos's Avatar
    Join Date
    Apr 2007
    Location
    Slovakia
    Posts
    27,538
    Vote Rating
    380
    jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future

      0  

    Default


    Node stays on error?
    Jozef Sakalos, aka Saki

    Education, extensions and services for developers at new http://extjs.eu
    News: Grid Search Plugin, ExtJS 5 Complex Data Binding using MVVM


  3. #23
    Sencha - Community Support Team jsakalos's Avatar
    Join Date
    Apr 2007
    Location
    Slovakia
    Posts
    27,538
    Vote Rating
    380
    jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future

      0  

    Default


    Oh, yes, now I remember. I've added insertChild later and forgotten to put it here. Thank you for pointing out.
    Jozef Sakalos, aka Saki

    Education, extensions and services for developers at new http://extjs.eu
    News: Grid Search Plugin, ExtJS 5 Complex Data Binding using MVVM


  4. #24
    Ext User cybersys's Avatar
    Join Date
    Feb 2009
    Posts
    40
    Vote Rating
    0
    cybersys is on a distinguished road

      0  

    Default just a suggestion

    just a suggestion


    I thiknk that a node.select when show context menu is a good approach because when i select a node and then right click to another for insert a new node the selected node stays until i insert the new node.

    It might be confusing for some people

    just a suggestion

    Thanks is really great job
    Still trying to Lear ExtJs

  5. #25
    Sencha - Community Support Team jsakalos's Avatar
    Join Date
    Apr 2007
    Location
    Slovakia
    Posts
    27,538
    Vote Rating
    380
    jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future

      0  

    Default


    Node name you're working with is always displayed in bold as first non-editable item of context menu. However, users sometimes "do not see" so I've implemented your suggestion.

    I've also released 1.0 stable version - there were no bugs reported so far, neither feature requests.
    Jozef Sakalos, aka Saki

    Education, extensions and services for developers at new http://extjs.eu
    News: Grid Search Plugin, ExtJS 5 Complex Data Binding using MVVM


  6. #26
    Ext User
    Join Date
    Feb 2009
    Posts
    60
    Vote Rating
    0
    wayned@escc is on a distinguished road

      0  

    Default


    I've added some code to allow for editable: false

    Please take a look and let me know if you think it's good enough to be included in your version.

    w://
    Attached Files

  7. #27
    Sencha - Community Support Team jsakalos's Avatar
    Join Date
    Apr 2007
    Location
    Slovakia
    Posts
    27,538
    Vote Rating
    380
    jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future

      0  

    Default


    Could you please describe the changes, what's purpose of them, etc.?
    Jozef Sakalos, aka Saki

    Education, extensions and services for developers at new http://extjs.eu
    News: Grid Search Plugin, ExtJS 5 Complex Data Binding using MVVM


  8. #28
    Ext User
    Join Date
    Feb 2009
    Posts
    60
    Vote Rating
    0
    wayned@escc is on a distinguished road

      0  

    Default


    Quote Originally Posted by jsakalos View Post
    Could you please describe the changes, what's purpose of them, etc.?
    Sure.

    I just changed it so that when 'editable: false' it:

    - doesn't error
    - shows a limited set of items in the context menu (only those items that do not pertain to editing).

    If you do a diff on the file on your site to the one I uploaded you'll see they are really only minor changes but it makes sense to have this working as the property (editable) exists but the functionality didn't.

    I have also extended this plugin to make it easier for people working with castle monorail bringing the following to the table:

    - ability to specify controller class
    - ability to specify actions for each operation (rename, add, delete etc...)

    This means that we can have a seperate controller action for each tree operation - cleaner, simpler, easier to understand.

    If anyone's interested I can upload.

    Cheers for a cool plugin

    w://

  9. #29
    Sencha - Community Support Team jsakalos's Avatar
    Join Date
    Apr 2007
    Location
    Slovakia
    Posts
    27,538
    Vote Rating
    380
    jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future jsakalos has a brilliant future

      0  

    Default


    Oh, yes, editable:false is unfinished work of mine. I'll complete it soon. No idea what's "castle monorail" though.
    Jozef Sakalos, aka Saki

    Education, extensions and services for developers at new http://extjs.eu
    News: Grid Search Plugin, ExtJS 5 Complex Data Binding using MVVM


  10. #30
    Ext User
    Join Date
    Feb 2009
    Posts
    60
    Vote Rating
    0
    wayned@escc is on a distinguished road

      0  

    Default


    Hey

    The file I uploaded has the editable: false functionality implemented so you can use that if you like

    Castle Monorail is a shiz hot MVC for .NET - The whole Castle stack is worth checking out if you're a .NET dev:

    http://www.castleproject.org/

    w://