1. #621
    Ext JS Premium Member
    Join Date
    May 2008
    Posts
    528
    Vote Rating
    0
    Eric24 is on a distinguished road

      0  

    Default Docs bug

    Docs bug


    [IMPLEMENTED]


    Config option "closable" is missing from Panel.

  2. #622
    Ext User
    Join Date
    Feb 2008
    Posts
    48
    Vote Rating
    0
    jove4015 is on a distinguished road

      0  

    Default triggerConfig option is wonderful!

    triggerConfig option is wonderful!


    [IMPLEMENTED]


    I just wanted to say, I finally stumbled across a hint about a "triggerConfig" option for TriggerField and it's a *wonderful* thing, it should definitely be added to the documentation!!

  3. #623
    Sencha User carol.ext's Avatar
    Join Date
    Jun 2007
    Location
    Littleton, Colorado, USA
    Posts
    673
    Vote Rating
    20
    carol.ext will become famous soon enough carol.ext will become famous soon enough

      0  

    Default BasicForm getValues asString default value

    BasicForm getValues asString default value


    [IMPLEMENTED]


    The documentation indicates the default value for the BasicForm.getValues() parameter "asString" is true (returns as string) :

    Code:
    @param {Boolean} asString (optional) false to return the values as an object (defaults to returning as a string)
    In the code an object is returned unless asString is passed in === true:
    Code:
        
    getValues: function(asString) {
        var fs = Ext.lib.Ajax.serializeForm(this.el.dom);
        if (asString === true) {
            return fs;
        }
        return Ext.urlDecode(fs);
    }
    code and @param taken from my 2.2.1 download.

  4. #624
    Sencha - Ext JS Dev Team Animal's Avatar
    Join Date
    Mar 2007
    Location
    Notts/Redwood City
    Posts
    30,502
    Vote Rating
    47
    Animal has a spectacular aura about Animal has a spectacular aura about

      0  

    Default


    [IMPLEMENTED]


    Quote Originally Posted by carol.ext View Post
    The documentation indicates the default value for the BasicForm.getValues() parameter "asString" is true (returns as string) :

    Code:
    @param {Boolean} asString (optional) false to return the values as an object (defaults to returning as a string)
    In the code an object is returned unless asString is passed in === true:
    Code:
        
    getValues: function(asString) {
        var fs = Ext.lib.Ajax.serializeForm(this.el.dom);
        if (asString === true) {
            return fs;
        }
        return Ext.urlDecode(fs);
    }
    code and @param taken from my 2.2.1 download.
    Ext.lib.Ajax.serializeForm returns a string.

    Ext.urlDecode decodes the strig into an object.

  5. #625
    Sencha - Ext JS Dev Team Animal's Avatar
    Join Date
    Mar 2007
    Location
    Notts/Redwood City
    Posts
    30,502
    Vote Rating
    47
    Animal has a spectacular aura about Animal has a spectacular aura about

      0  

    Default


    [IMPLEMENTED]


    Quote Originally Posted by jove4015 View Post
    I just wanted to say, I finally stumbled across a hint about a "triggerConfig" option for TriggerField and it's a *wonderful* thing, it should definitely be added to the documentation!!

    Well spotted. I'll write that one up.

  6. #626
    Sencha User carol.ext's Avatar
    Join Date
    Jun 2007
    Location
    Littleton, Colorado, USA
    Posts
    673
    Vote Rating
    20
    carol.ext will become famous soon enough carol.ext will become famous soon enough

      0  

    Default BasicForm getValues asString default value

    BasicForm getValues asString default value


    [IMPLEMENTED]


    Quote Originally Posted by Animal View Post
    Ext.lib.Ajax.serializeForm returns a string.

    Ext.urlDecode decodes the strig into an object.
    My response is "exactly". I am seriously trying to figure out how I am reading this wrong:

    @param {Boolean} asString (optional) false to return the values as an object (defaults to returning as a string)
    Using the Checkbox / Radio Group example I set a breakpoint in the Save button's handler. Then in the console call fp.getForm().getValues(). If I do not pass in a value for asString it returns an object, see attached screen shot from firebug. Is that not what is meant by default?

    basicForm.png

  7. #627
    Ext User
    Join Date
    Jul 2007
    Location
    Florida
    Posts
    9,996
    Vote Rating
    5
    mjlecomte will become famous soon enough mjlecomte will become famous soon enough

      0  

    Default


    [IMPLEMENTED]


    Quote Originally Posted by Eric24 View Post
    Config option "closable" is missing from Panel.
    I don't see where this config option is honored.

  8. #628
    Ext JS Premium Member watrboy00's Avatar
    Join Date
    Aug 2007
    Location
    Minneapolis, MN
    Posts
    473
    Vote Rating
    0
    watrboy00 is on a distinguished road

      0  

    Default


    [IMPLEMENTED]


    Quote Originally Posted by mjlecomte View Post
    I don't see where this config option is honored.
    In TabPanel.js...

    initTab checks the closable config option which adds 'x-tab-strip-closable' to the tab's dom helper config.

    Code:
    initTab : function(item, index){
        var before = this.strip.dom.childNodes[index];
        var cls = item.closable ? 'x-tab-strip-closable' : '';
        if(item.disabled){
            cls += ' x-item-disabled';
        }
        if(item.iconCls){
            cls += ' x-tab-with-icon';
        }
        if(item.tabCls){
            cls += ' ' + item.tabCls;
        }
    
        var p = {
            id: this.id + this.idDelimiter + item.getItemId(),
            text: item.title,
            cls: cls,
            iconCls: item.iconCls || ''
        };
        var el = before ?
                 this.itemTpl.insertBefore(before, p) :
                 this.itemTpl.append(this.strip, p);
    
        Ext.fly(el).addClassOnOver('x-tab-strip-over');
    
        if(item.tabTip){
            Ext.fly(el).child('span.x-tab-strip-text', true).qtip = item.tabTip;
        }
        item.tabEl = el;
    
        item.on('disable', this.onItemDisabled, this);
        item.on('enable', this.onItemEnabled, this);
        item.on('titlechange', this.onItemTitleChanged, this);
        item.on('iconchange', this.onItemIconChanged, this);
        item.on('beforeshow', this.onBeforeShowItem, this);
    }
    In findTargets it then checks the presence of 'x-tab-strip-close' to determine if the tab is closable.

    Code:
    findTargets : function(e){
        var item = null;
        var itemEl = e.getTarget('li', this.strip);
        if(itemEl){
            item = this.getComponent(itemEl.id.split(this.idDelimiter)[1]);
            if(item.disabled){
                return {
                    close : null,
                    item : null,
                    el : null
                };
            }
        }
        return {
            close : e.getTarget('.x-tab-strip-close', this.strip),
            item : item,
            el : itemEl
        };
    }
    IMO that closable should be a config of TabPanel's items but not of the TabPanel itself.
    Eric Berens
    Intranet Systems Manager @ Best Buy
    You should follow me on twitter here.

  9. #629
    Ext User
    Join Date
    Jul 2007
    Location
    Florida
    Posts
    9,996
    Vote Rating
    5
    mjlecomte will become famous soon enough mjlecomte will become famous soon enough

      0  

    Default


    [IMPLEMENTED]


    Ok, adding this to Ext.Panel docs:
    Code:
        /**
         * @cfg {Boolean} closable
         * Panels themselves do not directly support being closed, but some Panel
         * subclasses do (like {@link Ext.Window}) or a Panel Class within a Ext.TabPanel.
         * Specify <tt>true</tt> to enable closing in such situations. Defaults to <tt>false</tt>
         */

  10. #630
    Ext JS Premium Member watrboy00's Avatar
    Join Date
    Aug 2007
    Location
    Minneapolis, MN
    Posts
    473
    Vote Rating
    0
    watrboy00 is on a distinguished road

      0  

    Default


    [no change made]


    http://extjs.com/deploy/dev/docs/?class=Ext.Template

    Code:
    overwrite( Mixed el, Object/Array values, [Boolean returnElement] ) : HTMLElement/Ext.Element
    Applies the supplied values to the template and overwrites the content of el with the new node(s).
    Parameters:
    
        * el : Mixed
          The context element
        * values : Object/Array
          The template values. Can be an array if your params are numeric (i.e. {0}) or an object (i.e. {foo: 'bar'})
        * returnElement : Boolean
          (optional) true to return a Ext.Element (defaults to undefined)
    
    Returns:
    
        * HTMLElement/Ext.Element
          The new node or Element
    Shouldn't that be '[0]'?
    Eric Berens
    Intranet Systems Manager @ Best Buy
    You should follow me on twitter here.

Thread Participants: 182

  1. JeffHowden (3 Posts)
  2. Animal (64 Posts)
  3. tryanDLS (10 Posts)
  4. christocracy (1 Post)
  5. jarrod (2 Posts)
  6. jay@moduscreate.com (21 Posts)
  7. JTM (1 Post)
  8. vtswingkid (1 Post)
  9. young_matthewd (3 Posts)
  10. sjivan (1 Post)
  11. yogurtearl (1 Post)
  12. Condor (34 Posts)
  13. mdissel (2 Posts)
  14. steve.neill (4 Posts)
  15. mikegiddens (3 Posts)
  16. rmesser (1 Post)
  17. jweber (1 Post)
  18. aconran (8 Posts)
  19. vmorale4 (13 Posts)
  20. tof (4 Posts)
  21. stever (1 Post)
  22. berend (3 Posts)
  23. Jul (16 Posts)
  24. bone (2 Posts)
  25. timb (1 Post)
  26. punkrider (2 Posts)
  27. dolittle (4 Posts)
  28. papasi (1 Post)
  29. kimu (1 Post)
  30. willydee (2 Posts)
  31. dotnetCarpenter (1 Post)
  32. steven (3 Posts)
  33. DeyV (1 Post)
  34. cdomigan (1 Post)
  35. JorisA (2 Posts)
  36. MaxT (3 Posts)
  37. jsakalos (2 Posts)
  38. tellioglu (2 Posts)
  39. architect (1 Post)
  40. ksachdeva (1 Post)
  41. PFM (1 Post)
  42. evant (4 Posts)
  43. thesilentman (4 Posts)
  44. para (2 Posts)
  45. sj137 (6 Posts)
  46. J.C. Bize (3 Posts)
  47. Jonno70 (1 Post)
  48. splintor (9 Posts)
  49. mribbons (1 Post)
  50. danh2000 (1 Post)
  51. loeppky (2 Posts)
  52. mdm-adph (3 Posts)
  53. NBRed5 (1 Post)
  54. meej (1 Post)
  55. tobiu (1 Post)
  56. patspam (1 Post)
  57. gimbles (2 Posts)
  58. jan1234 (2 Posts)
  59. Ytorres (1 Post)
  60. aparajita (4 Posts)
  61. carol.ext (2 Posts)
  62. end-user (3 Posts)
  63. nicora (1 Post)
  64. devnull (4 Posts)
  65. AdamDawes (1 Post)
  66. mjlecomte (92 Posts)
  67. BlackICE1979 (1 Post)
  68. vincentc (1 Post)
  69. rednix (3 Posts)
  70. hansellh (1 Post)
  71. TaterSalad (1 Post)
  72. aptana_michelle (1 Post)
  73. Trixor (3 Posts)
  74. Iveco (1 Post)
  75. mscdex (4 Posts)
  76. watrboy00 (8 Posts)
  77. pic_Nick (1 Post)
  78. tohagan (1 Post)
  79. gimler (1 Post)
  80. smcguire36 (1 Post)
  81. ziesemer (2 Posts)
  82. balou (1 Post)
  83. yarmy (1 Post)
  84. jerrybrown5 (1 Post)
  85. abent (1 Post)
  86. lvanderree (4 Posts)
  87. Greenosity (1 Post)
  88. tjcrowder (18 Posts)
  89. treffer (2 Posts)
  90. SeaSharp (3 Posts)
  91. dhurlburtusa (1 Post)
  92. neshaug (2 Posts)
  93. tony_k (1 Post)
  94. Jim McCabe (1 Post)
  95. dyndan (1 Post)
  96. Hemlock (1 Post)
  97. runnersixty (1 Post)
  98. stoober (1 Post)
  99. battisti (1 Post)
  100. slobo (1 Post)
  101. plan-r (2 Posts)
  102. joeaudette (1 Post)
  103. paradawks (1 Post)
  104. saJoshua (7 Posts)
  105. t34 (6 Posts)
  106. markpele (1 Post)
  107. Gordon76 (1 Post)
  108. mankz (3 Posts)
  109. cblin (1 Post)
  110. jasonbronson (3 Posts)
  111. stebru (1 Post)
  112. Enes (1 Post)
  113. jburnhams (1 Post)
  114. david.james (1 Post)
  115. krystian (1 Post)
  116. erlando (1 Post)
  117. asteidle (1 Post)
  118. iamnoah (1 Post)
  119. molasses (1 Post)
  120. jonn (3 Posts)
  121. jhurst (1 Post)
  122. Starfall (14 Posts)
  123. creusois (1 Post)
  124. silvereen (1 Post)
  125. vilivili (2 Posts)
  126. jezmck (1 Post)
  127. nbourdeau (1 Post)
  128. YarivYaari (1 Post)
  129. luv2hike (1 Post)
  130. mrileyaz (1 Post)
  131. jmcneese (1 Post)
  132. treqx (1 Post)
  133. willdudziak (1 Post)
  134. NOSLOW (3 Posts)
  135. tomcheng76 (2 Posts)
  136. jove4015 (1 Post)
  137. xpurpur (1 Post)
  138. mknopp (1 Post)
  139. aurelien (2 Posts)
  140. nctag (5 Posts)
  141. pbuyle (1 Post)
  142. keckeroo (2 Posts)
  143. vcastel (1 Post)
  144. switch (1 Post)
  145. dcesarnascimento (1 Post)
  146. mirko (1 Post)
  147. mdkalman (1 Post)
  148. nb (1 Post)
  149. makana (2 Posts)
  150. fins (1 Post)
  151. NoahK17 (1 Post)
  152. Answerfor (1 Post)
  153. russn (1 Post)
  154. accilies (1 Post)
  155. SamuraiJack1 (1 Post)
  156. Eric24 (2 Posts)
  157. Funcracker (5 Posts)
  158. oxyum (1 Post)
  159. SoreGums (1 Post)
  160. Berni (1 Post)
  161. photomo (1 Post)
  162. nicktak (1 Post)
  163. don_luiz (2 Posts)
  164. wwarby (7 Posts)
  165. hAmpzter (1 Post)
  166. masuran (1 Post)
  167. ben_dog (3 Posts)
  168. thboileau (4 Posts)
  169. kds.chris (1 Post)
  170. salewski (1 Post)
  171. Mjollnir26 (1 Post)
  172. mikamikaze (1 Post)
  173. dreas (2 Posts)
  174. mschwartz (1 Post)
  175. jililv (2 Posts)
  176. TinKim (1 Post)
  177. zgrose (1 Post)
  178. martinjrb (1 Post)
  179. flinz (2 Posts)
  180. PierceSD (1 Post)
  181. dlgoodchild (1 Post)
  182. brian.moeskau (12 Posts)