[FIXED][2.2.1 build 3186] onDocMouseDown in ToolTip reversed logic

[sanderson]

I believe that this code is in ToolTip.js to allow tooltips to close if the user clicks elsewhere in the document while the tip is open and autoHide is off.

    onDocMouseDown : function(e){
        if(this.autoHide !== false && !e.within(this.el.dom)){
            this.disable();
            this.enable.defer(100, this);
        }
    }

However, for this to actually work, the line needs to be:

if(this.autoHide !== true && ...

Without this change, the tip will not close if autohide is off, and if autohide is on the tip will close by itself regardless.

Regards,
-scott

[evant]

If we make that change, that means a tooltip with autoHide: false will get hidden when the user clicks the document. Or am I missing something?

[sanderson]

Yes, exactly.

Currently, if you don't have a close button and autoHide is false, there's no way to close the tooltip.

Clicking on the document to close the tooltip only when autoHide is true makes no sense, because as soon as you mouse off the object with the tooltip, the tooltip will go away anyways.

[evant]

Right, I get you, fixed in SVN.

[sanderson]

Excellent, thank you.