1. #1
    Ext GWT Premium Member
    Join Date
    Jul 2008
    Posts
    33
    Vote Rating
    0
    Adam Ward is on a distinguished road

      0  

    Default [FIXED] [1.2.3] AbstractStoreSelectionModel calls onSelectChange() too early

    [FIXED] [1.2.3] AbstractStoreSelectionModel calls onSelectChange() too early


    The AbstractStoreSelectionModel calls the onSelectChange(M model, boolean select) before the classes internal variable selected is updated. The following lines in AbstractStoreSelectionModel.java (lines 309-311):
    Code:
    onSelectChange(model, true);    
    selected.add(model);    
    lastSelected = model;
    should be changed to:

    Code:
    selected.add(model); 
    lastSelected = model;
    onSelectChange(model, true);
    With the fix, we can now trust the selected member variable in the concrete implementation of onSelectChange(M, boolean).

  2. #2
    Software Architect
    Join Date
    Sep 2007
    Posts
    13,691
    Vote Rating
    107
    sven is just really nice sven is just really nice sven is just really nice sven is just really nice

      0  

    Default


    Yes, i already changed this Will be part of the next release

  3. #3
    Software Architect
    Join Date
    Sep 2007
    Posts
    13,691
    Vote Rating
    107
    sven is just really nice sven is just really nice sven is just really nice sven is just really nice

      0  

    Default


    Fixed in SVN.