[FIXED] [2.x] Destroying a Store doesn't destroy its underlying proxy

[mystix]

destroying a Store does not destroy its underlying DataProxy.

the following code resolves this

Ext.override(Ext.data.store, {
    destroy : function() {
        if (this.storeId || this.id) {
            Ext.StoreMgr.unregister(this);
        }

        if (this.proxy) {
            Ext.destroy(this.proxy);
        }

        this.data = null;
        this.purgeListeners();
    }
});

[Condor]

Shouldn't a store also destroy its reader?

[mystix]

yes it should. i was only concentrating on the Store though

[edit]
on 2nd thought, how would it do that?

[evant]

Just FYI, the proxy and the reader don't have destroy methods, but they probably should, at the very least to purge the listeners.

[mystix]

Just FYI, the proxy and the reader don't have destroy methods, but they probably should, at the very least to purge the listeners.

whoops... my bad... forgot to include my custom override (for the proxy):

Ext.override(Ext.data.DataProxy, {
    destroy: function() {
        this.purgeListeners();
    }
});
Ext.override(Ext.data.HttpProxy, {
    destroy: function() {
        // abort current request, if any
        if (this.activeRequest) {
            Ext.Ajax.abort(this.activeRequest);
        }

        Ext.data.HttpProxy.superclass.destroy.call(this);
    }
});

[mystix]

[friendly bump ]
affects 3.x too -- not sure how this weighs in with the new Ext.Direct stuff though.

p.s. @condor, re: Reader destruction, how would we do that?

[evant]

Committed both branches.

RE: direct, we need some good way of cancelling transactions, though I don't know there's a good way to handle that when we're considering request batching...

I'll mark this one as fixed now.