Thank you for reporting this bug. We will make it our priority to review this report.
  1. #1
    Ext JS Premium Member stever's Avatar
    Join Date
    Mar 2007
    Posts
    1,407
    Vote Rating
    6
    stever will become famous soon enough stever will become famous soon enough

      0  

    Default [FIXED][3.0] DateField

    [FIXED][3.0] DateField


    In DateField, this function checks to see if a value is set to true, after which it sets it to true. Wait, huh? I think the author meant to have a NOT (!) operator in there. But since the code has never likely been tested since the condition never happens, I'm not sure what other problems it will have one fixed... it does on('select', ...) twice, etc. I think someone needs to have another look at this class.

    PHP Code:
        onMenuHide: function(){
            if(
    this.afterInitial){
                
    this.afterInitial true;
                
    this.focus.defer(10this);
                
    this.menuEvents('un');
            }
        }, 

  2. #2
    Ext User
    Join Date
    Jul 2007
    Location
    Florida
    Posts
    9,996
    Vote Rating
    6
    mjlecomte will become famous soon enough mjlecomte will become famous soon enough

      0  

    Default


    Haven't looked at it, but it could have been set to something besides false/undefined, and someone wants to typecast it explicitly to boolean true also.

  3. #3
    Ext JS Premium Member stever's Avatar
    Join Date
    Mar 2007
    Posts
    1,407
    Vote Rating
    6
    stever will become famous soon enough stever will become famous soon enough

      0  

    Default


    I did a grep though all the source code and examples, and this is the only place it is found. I should have mentioned that before. My bad.

  4. #4
    Sencha - Architect Dev Team aconran's Avatar
    Join Date
    Mar 2007
    Posts
    9,366
    Vote Rating
    128
    aconran is a splendid one to behold aconran is a splendid one to behold aconran is a splendid one to behold aconran is a splendid one to behold aconran is a splendid one to behold aconran is a splendid one to behold aconran is a splendid one to behold

      0  

    Default


    Thanks for bringing this to our attention, we'll have a look.
    Aaron Conran
    @aconran
    Sencha Architect Development Team

  5. #5
    Sencha - Ext JS Dev Team evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    17,016
    Vote Rating
    650
    evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute

      0  

    Default


    Fixed, something a bit more sane is committed.
    Evan Trimboli
    Sencha Developer
    Twitter - @evantrimboli
    Don't be afraid of the source code!

  6. #6
    Ext JS Premium Member stever's Avatar
    Join Date
    Mar 2007
    Posts
    1,407
    Vote Rating
    6
    stever will become famous soon enough stever will become famous soon enough

      0  

    Default


    I am using DateField as a model for a ColorField, and was wondering what the reasoning is behind the turning off the event listeners when the menu is hidden? Not that it doesn't make sense, just that I don't see it happen elsewhere as a general pattern. Or I missed it. Could be that too...

Thread Participants: 3