Built RTL support for 3.0, mostly working

[mksoft]

Hi,

I've built RTL support for 3.0. Most of the stuff is working (trees are the exception). I've tested only on Firefox.

See the github repository for more info:
https://github.com/MeirKriheli/ExtJS-RTL

I have some questions though:

• Did I get the licensing right ? If not, please advise.
• What will it take to put it upstream (or at least parts of it, which will ease the efforts) ? for example I'm overriding some functions, just because the hard coded popup menu alignment to 'tl-bl?', etc.

Cheers
Meir

[abdo67]

Hi mksoft,

I visited your site and tried the EXT3.0 grid and combo examples with your RTL support.

Unfortunatelly, I still have the same problems that I faced with Yarriv solution for Ext2.x:
- in FF and in IE, the horizontal scrollbar appears to the right corner of the page as if the grid or combo are displayed to the right of a very wide page, and scrolling this bar to the left will cause the page content to disappear.
- in IE, when I click on a row of the RTL grid, the columns move to the right and become not alligned with the grid headers. the columns shift becomes bigger every time I click on a new row.

I hope that you will fix these problems.

Abdo

[mksoft]

There was an extra comma , which bombed IE (I hate this borwser, I usually don't test for it). Fixed.

I've tested with IE on windows and Firefox on Linux, no horizontal scrollbars, and columns are aligned as it should be when clicking rows or navigating the grid.

Please try again after the fix.

Still no answer on both of my questions above :-(

[abdo67]

Hi,

I have no more access to your site to try again:
-------------
Status: 500 Internal Server Error Content-Type: text/html
500 Internal Server Error

-----------

[mksoft]

Err, github is not my site, they are hosting git repositories, use git to clone the code locally

[elnove]

Hey MK,
You did a great job, RTLing ExtJS - the best I had seen so far !!

I'm playing around with it, one problem I found is on a datefield in a form, on FF 3 (3.0.11), it doesn't work (I use it in a field set).

other than that, things are great.

[mksoft]

elnove:

Can you post an example which I can test (and a possible screenshot) ?

P.S.
Thanks :-)

[elnove]

Hi Mk,
I just added 2 screen shots:
1. (update.gif), the state befor hitting the date field button - before the date selector window is opened.
2. after the click, when the date selector is opend.

there are 2 things that happend:
1. the date selector window is not aligning to the left of the field or button.
2. the scrreen scrolls to the right (look at the gup on the left that been added to the panel.

I think it had somthing to do with the alignTo() and/or other alignment methods. I'm also looking my self at that direction.

the following is the code that creates the form (it is nested within a panel and the panel is nested within a viewport).

createUserForm = function(config) {
    //Ext.apply(this, config);

    this.accountDetailsGroup = {
          width:300,
          xtype: 'fieldset',
          title:vfr.local.accountDetails,
          defaultType: 'textfield',
          style: 'position:relative;',
          items: [
                { 
                   fieldLabel: vfr.local.userName,
                   allowBlank: false,
                   msgTarget: vfr.consts.invalidMessagetarget,
                   name: 'userName'
                },
                { 
                   inputType: 'password', 
                   fieldLabel: vfr.local.password,
                   allowBlank: false,
                   msgTarget: vfr.consts.invalidMessagetarget,
                   name: 'password'
                 },
                { 
                   inputType:'password',
                   fieldLabel: vfr.local.confirmPassword,
                   allowBlank: false,
                   msgTarget:vfr.consts.invalidMessagetarget,
                   name: 'confirmPassword' 
                  }
        ]
    };

    this.userDetailsGroup = {
                 width: 300, 
                 xtype: 'fieldset',
                 title: vfr.local.userDetails,
                 defaultType: 'textfield',
                 style: 'position:relative;',
        items: [
                { fieldLabel: vfr.local.firstName, allowBlank: false,
                  msgTarget:  vfr.consts.invalidMessagetarget, name: 'firstName' },
                {  fieldLabel: vfr.local.lastName, allowBlank: false, 
                    msgTarget: vfr.consts.invalidMessagetarget, name: 'lastName' },
                { fieldLabel: vfr.local.address, allowBlank: false,
                   msgTarget: vfr.consts.invalidMessagetarget, name: 'address' },
                { fieldLabel: vfr.local.zip, allowBlank: false, 
                   msgTarget: vfr.consts.invalidMessagetarget, name: 'zip' },
                { xtype: 'combo', fieldLabel: vfr.local.city, allowBlank: false, 
                   msgTarget: vfr.consts.invalidMessagetarget, name: 'city' },
                { xtype: 'combo', fieldLabel: vfr.local.country, allowBlank: false, 
                   msgTarget: vfr.consts.invalidMessagetarget, name: 'country' },
                { xtype: 'combo', fieldLabel: vfr.local.state, allowBlank: false, 
                  msgTarget: vfr.consts.invalidMessagetarget, name: 'state' },
                { fieldLabel: vfr.local.email, allowBlank: false, 
                   msgTarget: vfr.consts.invalidMessagetarget, name: 'email' },
                 { xtype: 'datefield', fieldLabel: vfr.local.birthdate, allowBlank: false, 
                    msgTarget: vfr.consts.invalidMessagetarget, name: 'birthdate' }
        ]
    };


vfr.widgets.createUserForm.superclass.constructor.call(this, {
    frame: true,
    padding:10,
    autoScroll: true,
    autoHeight: false,
    title: vfr.local.addUser,
    defaults: { labelAlign: vfr.consts.labelsAlign },
    items: [
         this.accountDetailsGroup,
         this.userDetailsGroup
    ], 
    buttons: [{
            text: vfr.local.save,
            iconCls: 'i-disk',
            iconAlign: vfr.consts.buttonsIconAlign
        }, {
            text: vfr.local.cancel,
            iconCls: 'i-cross',
            iconAlign: vfr.consts.buttonsIconAlign
    }]
  });
 };  //end class


 Ext.extend(vfr.widgets.createUserForm, Ext.form.FormPanel, {
          //TODO:Write some overrides 
});

El.

[mksoft]

elnove, my laptop is being serviced, so I'll have to wait 'till it returns to figure this out (writing this on an eee pc 701, but can't do meaningful work on it).

[elnove]

thanks MK,
Using EE PC is great, I got one, but, never used it (or will use it) for deep coding

In the meanwhile I'll continue to look into the problem, may be I'll be able to help and solve it.

El.