Thank you for reporting this bug. We will make it our priority to review this report.
  1. #1
    Ext User
    Join Date
    Dec 2008
    Posts
    17
    Vote Rating
    0
    MrExt is on a distinguished road

      0  

    Default [FIXED] RowEditor: Fields reused without init state

    [FIXED] RowEditor: Fields reused without init state



    Not initialing originalvalues of reused fields cause that future rows to not detecting changes (field dirty) when the new value is equal to the original of previous row editing.

    publicvoid startEditing(int rowIndex, boolean doFocus) {


    for (int i = 0, len = cm.getColumnCount(); i < len; i++) {
    Field<Object> f = (Field<Object>) getItem(i);
    String dIndex = cm.getDataIndex(i);
    Object val = cm.getEditor(i).preProcessValue(record.get(dIndex));
    f.setValue(val);
    -> f.updateOriginalValue(val);
    values.add(val);
    }


    }



  2. #2
    Software Architect
    Join Date
    Sep 2007
    Posts
    13,971
    Vote Rating
    132
    sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light

      0  

    Default


    Please post a complete testcase that is demonstrating the issue.

  3. #3
    Software Architect
    Join Date
    Sep 2007
    Posts
    13,971
    Vote Rating
    132
    sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light

      0  

    Default


    Got it. thanks for reporting.

  4. #4
    Ext User
    Join Date
    Dec 2008
    Posts
    17
    Vote Rating
    0
    MrExt is on a distinguished road

      0  

    Default


    I will try next week.
    Only to clarify: I know RowEditor has its own isDirty() and does not check against originalValues but Store/Grid or GridView yes. So the changes are not reflected in the grid.

  5. #5
    Ext User
    Join Date
    Dec 2008
    Posts
    17
    Vote Rating
    0
    MrExt is on a distinguished road

      0  

    Default


    Quote Originally Posted by sven View Post
    Got it. thanks for reporting.
    Perfect. Thanks

  6. #6
    Software Architect
    Join Date
    Sep 2007
    Posts
    13,971
    Vote Rating
    132
    sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light sven is a glorious beacon of light

      0  

    Default


    Fixed in SVN.

Thread Participants: 1