[CLOSED][3.0 CORE] Ext core still have problems with json encode

[christianjianelli]

Ext core still have problems with json encode function. I believe that Ext.isDate is missing.

The Ext.encode returns the following error: TypeError: Ext.isDate is not a function.

[evant]

Which version? isDate doesn't appear in the SVN version of Ext core anywhere.

[Animal]

Just go to http://extjs.com/playpen/ext-core-la...amples/rating/

And type the following into the Firebug console:

Ext.util.JSON.encode({d: new Date()})

[evant]

This is odd, the core code doesn't contain anything to do with isDate, perhaps something is weird with the build script.

[Animal]

trunk/src/core/util/JSON.js:

    this.encode = function(o){
        if(typeof o == "undefined" || o === null){
            return "null";
        }else if(Ext.isArray(o)){
            return encodeArray(o);
        }else if(Ext.isDate(o)){
            return Ext.util.JSON.encodeDate(o);

[evant]

Not what I'm seeing:

this.encode = isNative ? JSON.stringify : function(o){
        if(typeof o == "undefined" || o === null){
            return "null";
        }else if(Ext.isArray(o)){
            return encodeArray(o);
        }else if(Object.prototype.toString.apply(o) === '[object Date]'){
            return Ext.util.JSON.encodeDate(o);

[evant]

Of course the obvious answer is just include isDate() in core, since the code saving from not including it is relatively minor.

[Animal]

OK, the build was wrong.

Because on that test page, Ext.util.JSON.encode.toSource() prints

"(function (o) {if (typeof o == "undefined" || o === null) {return "null";} else if (Ext.isArray(o)) {return encodeArray(o);} else if (Ext.isDate(o)) {return Ext.util.JSON.encodeDate(o);} else if (typeof o == "string") {return encodeString(o);} else if (typeof o == "number") {return isFinite(o) ? String(o) : "null";} else if (typeof o == "boolean") {return String(o);} else {var a = ["{"], b, i, v;for (i in o) {if (!useHasOwn || o.hasOwnProperty(i)) {v = o[i];switch (typeof v) {case "undefined":case "function":case "unknown":break;default:if (b) {a.push(",");}a.push(this.encode(i), ":", v === null ? "null" : this.encode(v));b = true;}}}a.push("}");return a.join("");}})"

[Animal]

Something's funny with SVN.

I just explicitly did an SVN Update on trunk/core/src/util, and it updated JSON.js with the code fix that Tommy put in on the 2nd.

That was after I did an SVN Update on the whole ext directory earlier today.

Could be that when the build is done, the SVN checkout is not working well.

[mystix]

the <ext>/core directory is marked as an external svn resource, so it won't be updated when updating <ext>. you'll need to explicitly update <ext>/core (using tortoisesvn / command line) to get the latest core.