[CLOSED][3.0rc2] GridFilter shows menu for columns without any filter

[xLP]

Hi,

- Sorry, I'm not used to reporting bugs in forums, but didn't find any bug tracker, please tell me if I do something wrong. I tried finding a similar thread but failed. -

I'm using Ext 3 RC 2, and I'm trying the grid filter sample from Ext 2 (couldn't find in Ext 3).
I have a grid with 4 columns, 2 have filters, 2 don't. When I popup the menu for a column which has no filter, I get a "Filter" item with empty submenu. After poping menu on a column which has a filter, if a re-popup on a column without filter, I'll get the same filter as for the previous columns.

I'm not a javascript expert so I fixed it the easiest I could, it may not be so good, please tell me if so.

In GridFilters.js, onMenu (line 153-154 for me) :
this.menu.setVisible(filter !== undefined && filter !== null);
this.sep.setVisible(filter !== undefined && filter !== null);

=> I've added this "&& filter !== null", because as a matter of fact, at execution time, filter === null for columns without filter. This now works fine. I hope this helps improving this great framework!

Best regards

[mystix]

i've moved your thread from the 2.x Bugs forum to the 3.x Bugs forum.

additionally, you should edit your initial post and add these little nuggets of information:
http://extjs.com/forum/showthread.php?t=71015

[mjlecomte]

Thanks for your post. At the moment that example is not compatible with Ext 3.

It would be helpful if you could post some code (as Mystix suggested above) that illustrates the situation so we could test against it. Probably the best would be to something like the array grid example, which has static data, and modify that similar to your situation.

[xLP]

Ext version tested:

• Ext 3.0 rev RC2

Browser versions tested against:

• FF3.0.10 (firebug 1.3.3 installed)

Operating System:

• WinXP Pro

Description:

• Sorry, can't upload I'm getting kicked constantly by the forum. Might be because I'm on a load balancer with several IPs?

Test Case:
Take the grid example, DO NOT RUN IT FROM "file://" (where suprisingly for me the bug doesn't appear), run it over a web browser.
In grid-filter.js, around line 45, comment out "{type: 'date', dataIndex: 'date'},".

Open the URL in browser, click the "date" colmn, you

Debugging already done:

• In GridFilter.js, in onMenu, filter appears to be equal to null.

Possible fix:
See last post.

[mjlecomte]

GridFilter ux has been updated for 3.x and posted in svn, updating status of this thread to CLOSED.