[1.2.4] Modified records are deleted across load operations (e.g., during paging).

[matthewdfleming]

The ListStore is supposed to keep modified records across load calls but it does not

Here is the onLoad method of ListStore. the call to removeAll() deletes the records in the store...

  
protected void onLoad(LoadEvent le) {
    this.config = (ListLoadConfig) le.config;

    Object data = le.data;

    removeAll();

    if (data instanceof List) {
      List<M> list = (List) le.data;
      all = list;

    } else if (data instanceof ListLoadResult) {
      all = ((ListLoadResult) data).getData();
    }

    for (M m : all) {
      registerModel(m);
    }

    if (le.config instanceof ListLoadConfig) {
      ListLoadConfig config = (ListLoadConfig) le.config;
      if (config.getSortInfo().getSortField() != null) {
        sortInfo = config.getSortInfo();
      } else {
        sortInfo = new SortInfo();
      }
    }

    if (filtersEnabled) {
      filtersEnabled = false;
      applyFilters(filterProperty);
    }
    if (storeSorter != null) {
      applySort(true);
    }
    fireEvent(DataChanged, createStoreEvent());
  }

[sven]

This is not a bug but a feature requestment. Moving this to help forum so that moer people see it.

[matthewdfleming]

Here's the method that made me think it was a bug:

  /**
   * Gets all records modified since the last commit. Modified records are
   * persisted across load operations (e.g., during paging).
   * 
   * @return a list of modified records
   */
  public List<Record> getModifiedRecords() {
    return new ArrayList<Record>(modified);
  }

[sven]

Reloading a store deletes all data in it. You can extend ListStore to add this feature if you need it. However this can end up in a memoryleak. I will correct the javadoc

[matthewdfleming]

Anything in particular that I should look out for with regards to a memory leak?