Thank you for reporting this bug. We will make it our priority to review this report.
  1. #1
    Ext GWT Premium Member
    Join Date
    Jul 2009
    Posts
    104
    Vote Rating
    0
    VadimV1144 is on a distinguished road

      0  

    Default [FIXED][GXT 2.0.1] TreeGrid and toggle on double click

    [FIXED][GXT 2.0.1] TreeGrid and toggle on double click


    Hi, this is not a bug, but a code consistency issue.

    In the class TreeGrid :

    Method
    Code:
     public void toggle(M model) {..}
    is called within the
    Code:
    protected void onClick(GridEvent<M> e){...}
    to perform the tree expansion/collapse when the little arrow is single clicked.
    However, the Double Click is performed the following method is called
    Code:
     
    protected void onDoubleClick(GridEvent<M> e) {
        super.onDoubleClick(e);
        M m = e.getModel();
        if (m != null) {
          TreeNode node = findNode(m);
          setExpanded(node.m, !node.expanded);
        }
      }
    As you can see it totally duplicates the
    Code:
     public void toggle(M model) {..}
    and if I want to change the toggle behavior I have to override 2 methods instead of one.
    Please change above method to following:
    Code:
     
    protected void onDoubleClick(GridEvent<M> e) {
        super.onDoubleClick(e);
        toggle(e.getModel());
      }

  2. #2
    Sencha - GXT Dev Team darrellmeyer's Avatar
    Join Date
    May 2007
    Location
    Washington, DC
    Posts
    2,242
    Vote Rating
    2
    darrellmeyer is on a distinguished road

      0  

    Default


    This bug is fixed in the releases/2.1 branch and is now available in the 2.1.1-beta release available here.

Thread Participants: 1