Thank you for reporting this bug. We will make it our priority to review this report.
  1. #1
    Touch Premium Member jeffcrilly's Avatar
    Join Date
    May 2008
    Posts
    89
    Vote Rating
    0
    jeffcrilly is on a distinguished road

      0  

    Default [OPEN-575] roweditor: column-drag-drop, resize problems

    [OPEN-575] roweditor: column-drag-drop, resize problems


    http://www.extjs.com/deploy/dev/exam...ow-editor.html

    I've been integrating the very nice roweditor ux into an app I'm working on, and in the process of "testing for bulletproofness" noticed some issues with the roweditor ux.

    Issue A : data-out-of-sync-when-grid-columns-are-reordered

    One major (imo) issue is the reordering of columns while the editor is active.
    1) go to the demo page - i.e. the official extjs samples (link is above).
    2) double click to start editing a row.
    3) drag a column, e.g. put salary in front of name.

    Notice that the fields in the editor are not updated.

    Reproducibility: This appears to be reproducible on the extjs demo page which (afaict) is running 3.1.1.

    [edit] a workaround is to disable column drag/drop. Though this behavior is then inconsistent with other places in the app.

    [edit] Ideally, the editor (imo) should "cancel" the changes, even if a cell is dirty.
    Alternatively, the editor ~could~ prompt the user, but this seems tedious.
    My expectation is the user gave up on editing once the reorder task started.

    [edit] attached screenshot from extjs demo page


    Issue B - row-editor-controls-do-not-refresh-on-resize

    Another issue I noticed is when the editor is used in a "resizeable" window.
    On resize the editor buttons are not updated.
    I worked around this problem by adding a doing a "refreshFields" on the "resize" event.

    Reproducibility: I am currently using 3.0 and have not verified this issue w/ 3.1.1.
    However a brief scan of the 3.1.1 roweditor code leads me to believe this is an issue w/ 3.1.1 also.

    (apologies if this has been covered. I did a search but nothing relevant seemed to pop up.)

    jeff
    Attached Images

  2. #2
    Sencha User
    Join Date
    Sep 2009
    Location
    Romania
    Posts
    2
    Vote Rating
    0
    raluca is on a distinguished road

      0  

    Default Issues with the roweditor - reorder columns

    Issues with the roweditor - reorder columns


    I'm having the same issue. Any chance of getting these issues fixed in the near future?

  3. #3
    Sencha - Sencha Touch Dev Team Jamie Avins's Avatar
    Join Date
    Mar 2007
    Location
    Redwood City, California
    Posts
    3,661
    Vote Rating
    21
    Jamie Avins is a jewel in the rough Jamie Avins is a jewel in the rough Jamie Avins is a jewel in the rough Jamie Avins is a jewel in the rough

      0  

    Default


    It's an open issue, we'll get to them as soon as we can. Note that UX components are typically considered a lower priority than other components.

  4. #4
    Ext JS Premium Member
    Join Date
    Mar 2010
    Posts
    8
    Vote Rating
    0
    JimmyInMD is on a distinguished road

      0  

    Default


    Any updates or workarounds for this?

    Thanks!

  5. #5
    Sencha User
    Join Date
    Sep 2009
    Location
    Romania
    Posts
    2
    Vote Rating
    0
    raluca is on a distinguished road

      0  

    Default No update

    No update


    I just disabled the column move option on the grids that use an ux editor. I didn't really need the column move option anyway. I did not looked for another solution.

  6. #6
    Ext User
    Join Date
    Aug 2009
    Posts
    5
    Vote Rating
    0
    Bdfy is on a distinguished road

      0  

    Default


    Quote Originally Posted by raluca View Post
    I just disabled the column move option on the grids that use an ux editor. I didn't really need the column move option anyway. I did not looked for another solution.
    In 3.1.1 all OK - I dont use 3.2 because this bug.

  7. #7
    Sencha User
    Join Date
    Apr 2010
    Posts
    100
    Vote Rating
    0
    Dipish is an unknown quantity at this point

      0  

    Default


    Bdfy, Just checked 3.1.1, same thing. Could figure out what's wrong with that...

  8. #8
    Ext User
    Join Date
    Apr 2010
    Location
    Russian Federation
    Posts
    9
    Vote Rating
    0
    dead_man is on a distinguished road

      0  

    Default


    I changed the script and corrected problem with column resize. Tested on Firefox 3.6.3, IE6, Opera 10, Google Chrome 4.1. Please test and inform me.

    There is still column movement bug.
    Last edited by dead_man; 10 May 2010 at 10:27 PM. Reason: Attachment deleted. See lastest post

  9. #9
    Sencha User
    Join Date
    Apr 2010
    Posts
    100
    Vote Rating
    0
    Dipish is an unknown quantity at this point

      0  

    Default


    I don't experience column resize problem, this is working fine. But the fields layout crashes on column move (i.e. reordering columns)

  10. #10
    Ext User
    Join Date
    Feb 2010
    Location
    KlaipÄ—da
    Posts
    16
    Vote Rating
    0
    mdmitry is on a distinguished road

      0  

    Default


    I've done a little investigation on this bug.

    In function initFields there's a line: this.removeAll(false); - remove all editors from RowEditor, and it removes all extraCls = 'x-box-item' from all editors (@ ContainerLayout::onRemove)

    So extraCls is attached to editors only once during rendering (ContainerLayout::configureItem), but removed on first detach from container.

    So my simple & dirty fix would be
    Code:
        initFields: function(){
            ...
            for(var i = 0, len = cm.getColumnCount(); i < len; i++){
                ...
                this.insert(i, ed);
                if (typeof(this.layout) == 'object') {
                    var wrap = ed.wrap ? ed.wrap : ed;
                    wrap.addClass(this.layout.extraCls);
                    this.afterRender();
                }
            }
            this.initialized = true;
        },
    edit: my bug is actually that after reordering columns a couple of times (or doing grid reconfigure()) editor fields mess up.

    roweditbug.png