[FIXED] MultiSlider beforechange event does not indicate which thumb changed

[yakovsh]

In MultiSlider.js, the following code appears in setValue():

if (v !== thumb.value && this.fireEvent('beforechange', this, v, thumb.value) !== false) {
            thumb.value = v;
            .....

It does not indicate the thumb that is being changing unlike the code in the change event. It needs to be modified to read:

if (v !== thumb.value && this.fireEvent('beforechange', this, v, thumb.value, thumb) !== false)

[edspencer]

Makes sense - this is now present in svn and will be part of 3.2.1 and later

[Animal]

This is one of the reasons why a switch to using an EventObject would be very nice.

Not backwards compatible, and a huge upheaval, but I'd make the changes in my app.

Just look at the way the arguments list to various events have grown organically. If all events just injected properties into an object that would future proof event handling.

Maybe the fire method which calls the handler could test and call the handler in either way depending on a setting.

It could unpack the event object's properties as separate args if the old version is being used?

I know this is unlikely to change, but just thought I'd mention it.

[evant]

It would be nice, I suggested it a few years ago, however I think it would just end up breaking way too much code.

[yakovsh]

Makes sense - this is now present in svn and will be part of 3.2.1 and later

It might make more sense to pass the thumb index as opposed to the actual thumb object. This is how setValue() itself works

[edspencer]

It might make more sense to pass the thumb index as opposed to the actual thumb object. This is how setValue() itself works

I don't think so - I'd rather just pass back the thumb object from which the value can be interrogated, and remove thumb.value from the list of event handler arguments. Can't do this until the next major release though as it is guaranteed to break people's applications.