Thank you for reporting this bug. We will make it our priority to review this report.
  1. #1
    Sencha User
    Join Date
    Mar 2010
    Location
    Baltimore, MD
    Posts
    33
    Vote Rating
    1
    yakovsh is on a distinguished road

      0  

    Default [FIXED] MultiSlider beforechange event does not indicate which thumb changed

    [FIXED] MultiSlider beforechange event does not indicate which thumb changed


    In MultiSlider.js, the following code appears in setValue():
    Code:
    if (v !== thumb.value && this.fireEvent('beforechange', this, v, thumb.value) !== false) {
                thumb.value = v;
                .....
    It does not indicate the thumb that is being changing unlike the code in the change event. It needs to be modified to read:

    if (v !== thumb.value && this.fireEvent('beforechange', this, v, thumb.value, thumb) !== false)

  2. #2
    Sencha - Community Support Team edspencer's Avatar
    Join Date
    Jan 2009
    Location
    Palo Alto, California
    Posts
    1,939
    Vote Rating
    7
    edspencer is a jewel in the rough edspencer is a jewel in the rough edspencer is a jewel in the rough

      0  

    Default


    Makes sense - this is now present in svn and will be part of 3.2.1 and later
    Ext JS Senior Software Architect
    Personal Blog: http://edspencer.net
    Twitter: http://twitter.com/edspencer
    Github: http://github.com/edspencer

  3. #3
    Sencha - Ext JS Dev Team Animal's Avatar
    Join Date
    Mar 2007
    Location
    Notts/Redwood City
    Posts
    30,483
    Vote Rating
    35
    Animal has a spectacular aura about Animal has a spectacular aura about

      0  

    Default


    This is one of the reasons why a switch to using an EventObject would be very nice.

    Not backwards compatible, and a huge upheaval, but I'd make the changes in my app.

    Just look at the way the arguments list to various events have grown organically. If all events just injected properties into an object that would future proof event handling.

    Maybe the fire method which calls the handler could test and call the handler in either way depending on a setting.

    It could unpack the event object's properties as separate args if the old version is being used?

    I know this is unlikely to change, but just thought I'd mention it.

  4. #4
    Sencha - Ext JS Dev Team evant's Avatar
    Join Date
    Apr 2007
    Location
    Sydney, Australia
    Posts
    16,115
    Vote Rating
    507
    evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute evant has a reputation beyond repute

      0  

    Default


    It would be nice, I suggested it a few years ago, however I think it would just end up breaking way too much code.
    Evan Trimboli
    Sencha Developer
    Twitter - @evantrimboli
    Don't be afraid of the source code!

  5. #5
    Sencha User
    Join Date
    Mar 2010
    Location
    Baltimore, MD
    Posts
    33
    Vote Rating
    1
    yakovsh is on a distinguished road

      0  

    Default


    Quote Originally Posted by edspencer View Post
    Makes sense - this is now present in svn and will be part of 3.2.1 and later
    It might make more sense to pass the thumb index as opposed to the actual thumb object. This is how setValue() itself works

  6. #6
    Sencha - Community Support Team edspencer's Avatar
    Join Date
    Jan 2009
    Location
    Palo Alto, California
    Posts
    1,939
    Vote Rating
    7
    edspencer is a jewel in the rough edspencer is a jewel in the rough edspencer is a jewel in the rough

      0  

    Default


    Quote Originally Posted by yakovsh View Post
    It might make more sense to pass the thumb index as opposed to the actual thumb object. This is how setValue() itself works
    I don't think so - I'd rather just pass back the thumb object from which the value can be interrogated, and remove thumb.value from the list of event handler arguments. Can't do this until the next major release though as it is guaranteed to break people's applications.
    Ext JS Senior Software Architect
    Personal Blog: http://edspencer.net
    Twitter: http://twitter.com/edspencer
    Github: http://github.com/edspencer

Thread Participants: 3

film izle

hd film izle

film sitesi

takipci kazanma sitesi

takipci kazanma sitesi

güzel olan herşey

takipci alma sitesi

komik eğlenceli videolar