PDA

View Full Version : [INFOREQ] Ext.ux.FieldLabeler Doesn't Honor Margins



t00bs
17 Nov 2010, 6:35 PM
Ext version tested:

Ext 3.2.1


Adapter used:

ext


css used:

only default ext-all.css


Browser versions tested against:

FF3 (firebug 1.5.4 installed)


Operating System:

Fedora 13


Description:

I noticed that when placing FieldLabeler plugged fields alongside each other in a row using a container with hbox layout that the field margins were not being honored so fields were butted up against each other which is really ugly. When I removed the FieldLabeler plugin the margin problem went away (except, alas, no field labels!).


This seems to be offending snippet in Ext.ux.FieldLabeler,


if (this.nextSibling()) {
this.margins = {
top: 0,
right: 0,
bottom: this.positionEl.getMargins('b'),
left: 0
};
}

Adding this code fixes the problem.


if (this.nextSibling()) {
this.margins = this.margins || {
top: 0,
right: 0,
bottom: this.positionEl.getMargins('b'),
left: 0
};
}

--t00bs.

meroy
4 Dec 2010, 3:47 AM
Can you provide a test case as described in your description. Thanks.

devtig
6 Dec 2010, 10:25 AM
t00bs, if you want this to be fixed in the next version of Ext, then post the test case that demonstrates the error. The dev team should be able to copy paste it in their browser, reproduce the error and fix it (if indeed broken).