PDA

View Full Version : [FIXED]Grouping grid generate invalid html



steffenk
4 Mar 2011, 9:42 AM
Go to
http://dev.sencha.com/deploy/ext-4.0-pr3/examples/grid/groupgrid.html

From column menu "Name" group by this field

This is the generated first group:

<tr class="x-grid-group-hd "><td "="" style="padding-left:0px;" colspan="2" class="x-grid-cell"><div class="x-grid-group-title">Group: Cheesecake Factory</div></td></tr>

steffenk
5 Mar 2011, 5:18 AM
Reason for this is a superfluous quote in the template.

pr3, ext-all-debug line 13854 should be:


// group row tpl
'<tr class="' + Ext.baseCSSPrefix + 'grid-group-hd ' + (this.startCollapsed ? this.hdCollapsedCls : '') + '"><td class="' + Ext.baseCSSPrefix + 'grid-cell" colspan="' + parent.columns.length + '" {[this.indentByDepth(values)]}><div class="' + Ext.baseCSSPrefix + 'grid-group-title">' + this.groupHdTpl + '</div></td></tr>',

steffenk
5 Mar 2011, 6:21 AM
btw - i would prevent such super long lines, as you see it's error-proned as they are not readable completely in IDE.

steffenk
6 Mar 2011, 4:44 AM
push - 10 second fix :)

evant
6 Mar 2011, 3:27 PM
This has been resolved.

steffenk
7 Mar 2011, 5:33 AM
Thanks!