PDA

View Full Version : [FIXED] TreeDragSource does not allow moving both the leafs and the nodes in same tree



pete_by
29 Nov 2011, 11:56 AM
Change: bug's title misses NOT word: "does NOT allow"

Current implementation does not allow moving both leafs and nodes in the same tree. Only option is possible in the same time (even in single selection mode). This is because TreeDragSource#onDragStart method tests TreeSource only for LEAF or NODE, and not BOTH. This makes hard to implement editable hierarchies.


if (getTreeGridSource() == TreeSource.LEAF) {
...
} else { // else NODE or BOTH
...
for (M item : selected) {
if (getWidget().isLeaf(item)) { // here's the problem, we reject the leafs even // if getTreeGridSource()== BOTH
event.setCancelled(true);
return;
} else {
nonLeafKeys.add(kp.getKey(item));
}
...
}

Colin Alworth
30 Nov 2011, 3:22 PM
Thanks for the report - I modified the title as you suggested. We'll update this thread when a working revision is available.

darrellmeyer
6 Dec 2011, 11:31 AM
This is fixed in SVN (rev 1969) for both tree and treegrid. Changes will go out in our beta release this week.

darrellmeyer
12 Dec 2011, 6:53 PM
Fixed in beta 1.