PDA

View Full Version : [FIXED] ScrollSupport for Vertical[Horizontal]LayoutContainer not implemented?



raivis
20 Dec 2011, 11:10 PM
I don't know if it is not implemented or if it is supposed to be like that and one should implement ScrollSupport himself.
ScrollSupport for CssFloatLayoutContainer and FlowLayoutContainer:


@Override
public ScrollSupport getScrollSupport() {
if (scrollSupport == null) {
scrollSupport = new DefaultScrollSupport(getContainerTarget());
}
return scrollSupport;
}


ScrollSupport for PortalLayoutContainer:


public AutoScrollSupport getAutoScrollSupport() {
if (scrollSupport == null) {
scrollSupport = new AutoScrollSupport(getElement());
}
return scrollSupport;
}


ScrollSupport for VerticalLayoutContainer and HorizontalLayoutContainer:


@Override
public ScrollSupport getScrollSupport() {
return scrollSupport;
}


ScrollSupport for last two is never created thus null is returned. Ofcourse one could create his/her own ScrollSupport and set it manually. Just wanted to know if it is supposed to be that way or it is not yet implemented in Vertcal and Horizontal LayoutContainers?

MarcT
25 Jan 2012, 12:10 PM
I am also looking for an answer to this question. Seems like an oversight on Sencha's part, as adding scrolling to VLC & HLC should be as easy as possible (in fact, I'd really like them to just expose the setScrollMode() function directly from the container).

But even if Sencha has decided not to make it easy for us, a definite answer would be helpful.

nbuesing
10 Feb 2012, 2:16 PM
I too would like to know if this is something planned to be implemented, or if this is intentional?

Can someone please given an update on this.

Thanks.

WesleyMoy
17 Feb 2012, 3:16 PM
Thanks for pointing this out. I've filed a ticket against the team to take a look at why this is inconsistent. I'll update this thread with any changes we make.

lefke123
21 Feb 2012, 2:56 AM
We've just encountered this issue as well, and looking at the most recent code (revision 2195) it's not included yet. As a workaround, just set the scroll support with:

container.setScrollSupport(new DefaultScrollSupport(container.getElement()));

But I agree with MarcT that setScrollMode would be an excellent delegate in the container.

I'd like to know if this is something that will be included in the final 3.0 beta, or not? Thanks in advance.

darrellmeyer
7 Mar 2012, 10:32 AM
getScrollSupport now creates a new instance as needed everywhere. We also added get / set ScrollMode delegates to the container's that implement HasScrollSupport. Changes are in SVN and will go out in next release.

WesleyMoy
28 Mar 2012, 2:56 PM
This inconsistency has been corrected in the Ext GWT 3.0 Release Candidate. Please upgrade your copy of Ext GWT and try your test case again. While we're confident that we've addressed this issue, please reply if you notice any continued problems after upgrading. Again, thanks for taking the time to report and describe this bug.

margozzi
14 Oct 2013, 12:19 PM
Setting ScrollMode to AUTO doesn't work for me. Did other actuall yget this to work?

Colin Alworth
23 Oct 2013, 4:17 PM
Margozzi, are you setting the height/width of the container to be less than the size of the contents?

For HLC and VLC it rarely makes sense to have a scrollbar - these containers are designed to use up all remaining space, rather than be used as stacks of items. In general, check out CssFloatLC or FlowLC for this kind of thing, or perhaps some of the document-based containers in GWT itself.