PDA

View Full Version : [CLOSED] Ext.grid.plugin.CellEditing is broken when used with Checkbox Selection Model and cb



sajohns4
16 Feb 2012, 7:37 AM
This change should be put in with the 4.1 release...its annoying to have to register a listener to prevent a checkbox click when you already know the columns that are editable.

REQUIRED INFORMATION

Ext version tested:


Ext 4.07 - 4.1.b2



Browser versions tested against:


All



Description:


Cell Editors with checkbox selection models break if you dont add a beforeedit listener



Steps to reproduce the problem:


have a grid with a checkbox selection model and also 1+ editable cells via the plugin, click the checkbox - columnHeader.getEditor is undefined



The result that was expected:


no javascript error...no editor appears as none was configured



The result that occurs instead:


columnHeader.getEditor is not a function



Test Case:







HELPFUL INFORMATION

Possible fix:
You already know if the cell clicked was editable or not...Ext.grid.plugin.CellEditing.startEdit should be modified to: a) !context.column.getEditor or b) !columnHeader.getEditor

if (!context.column.getEditor || me.beforeEdit(context) === false || me.fireEvent('beforeedit', context) === false || context.cancel) {
if (columnHeader && (!columnHeader.getEditor || !columnHeader.getEditor(record))) {


Unacceptable Solution:
grid.addListener('beforeedit', function(obj) {
return Ext.isDefined(obj.column.getEditor);
});

mitchellsimoens
16 Feb 2012, 12:15 PM
I cannot reproduce this in our latest code.