PDA

View Full Version : [FIXED] 4.1.0: HtmlEditor doubles new lines in WebKit



skyboyer
28 Dec 2012, 12:45 AM
it is reproducible on my 4.0.5 and on 4.1.0 (http://try.sencha.com/extjs/4.1.0/docs/Ext.form.field.HtmlEditor.2/) as well
1. create line with some text
2. go to the start of line and press Enter
Actual: two linebreaks are inserted
Expected: only one
It is related to isWebKit branch in Ext.form.field.HtmlEditor.fixKeys' code.
I have no idea why it have been done in such way but as for WebKit Enter really inserts two <br>s.
Is it feature? Or is it workaround for some WebKit-related issue?

mitchellsimoens
28 Dec 2012, 7:32 AM
In 4.1.2+ it inserts <div><br></div> which will give same result really.

skyboyer
29 Dec 2012, 1:51 AM
I would be happy if you clarify why it was done in such way(maybe per comment to appropriate commit in your codebase).
It is easy to patch locally this part but I would omit new issues related to such patching.