PDA

View Full Version : [FIXED] ComboBox and BoundList pageSize inconsistency



Daniil
8 Jan 2013, 10:11 PM
REQUIRED INFORMATION

Ext version tested:

Ext 4.2.0 beta

Description:

The pageSize config option of ComboBox and BoundList confuses a bit. The name of the config option assumes that it can be used to manage page size, but according to the sources it is actually used as a boolean to show or not a PagingToolbar (also it is used in the ComboBox's doQuery, but again as a boolean). And the page size is actually managed by the Store's pageSize. Yes, it works because JavaScript interprets 0 as false, and not 0 as true. But I am talking about the inconsistency.
I assume this thing just stays since ExtJS 3 where the ComboBox's pageSize is really used as a number. But maybe is it time to change? Maybe a boolean config like "enablePaging" or "showPagingToolbar" would be better. Or are you planning to pass the ComboBox's pageSize to its Store's pageSize?
Actually, it is reported in the docs (http://docs.sencha.com/ext-js/4-1/#!/api/Ext.form.field.ComboBox-cfg-pageSize), but it doesn't look just a doc issue.

evant
8 Jan 2013, 10:47 PM
Yes, the pageSize config is essentially just a boolean now because paging is handled by the store itself. It's mostly a backwards compatibility thing, but we should probably phase out the config for something a bit clearer.

SimoAmi
13 Aug 2013, 7:41 AM
Hi,
It makes sense to at least mark the property as deprecated, or document the new behavior just like in the PagingToolbar documentation.