PDA

View Full Version : [FIXED] Direct call doesn't work with buffering disabled in 4.2.0



rtassi
3 Apr 2013, 4:53 AM
Direct calls don't work anymore from 4.1.1a-gpl to 4.2.0-gpl when buffering is disabled (Ext.direct.RemotingProvider.enableBuffer = false).

I found that in function Ext.direct.RemotingProvider.queueTransaction transactions are not buffered anymore, due to a recent change in 4.2.0:

FROM 4.2.0-gpl:


if (enableBuffer) {
me.callBuffer.push(transaction);

if (!me.callTask) {
me.callTask = new Ext.util.DelayedTask(me.combineAndSend, me);
}

me.callTask.delay(Ext.isNumber(enableBuffer) ? enableBuffer : 10);
} else {
me.combineAndSend(); // here me.callBuffer is always empty
}

FROM 4.1.1a-gpl:


me.callBuffer.push(transaction);

if (enableBuffer) {

if (!me.callTask) {
me.callTask = new Ext.util.DelayedTask(me.combineAndSend, me);
}

me.callTask.delay(Ext.isNumber(enableBuffer) ? enableBuffer : 10);
} else {
me.combineAndSend();
}

mitchellsimoens
3 Apr 2013, 5:26 AM
Thanks for the report! I have opened a bug in our bug tracker.