PDA

View Full Version : [FIXED] [4.2.2] Grid panel's base class 'x-grid' is missing when define a custom cls



Phantom
21 Oct 2013, 12:20 AM
Ext version tested:

Ext 4.2.2.1144


Browser versions tested against:

IE9
IE8
FF24 (firebug 1.11.4 installed)
Chrome 29
Opera 12


Description:
I have created a class which extends Ext.grid.Panel and which has a custom value for 'cls' property:

https://fiddle.sencha.com/#fiddle/136



Ext.define('MyApp.DataSearchGrid', {
extend : 'Ext.grid.Panel',
alias : 'widget.datasearchgrid',
cls : 'x-data-search-grid'
});


With ExtJS v4.2.1.883 the outer grids div element looks as following:


<div id="DataSearchGrid-1162" class="x-panel x-fit-item x-panel-default x-grid x-data-search-grid" style="margin: 0px; height: 223px; width: 1068px;">
...
</div>


While with ExtJS v4.2.2.1144 that div element becomes:


<div id="DataSearchGrid-1162" class="x-panel x-data-search-grid x-fit-item x-panel-default" style="margin: 0px; height: 223px; width: 1068px;">
...
</div>

i.e. 'x-grid' class is missing.

The reason for this problem is in class Ext.panel.Table line 394:

me.cls = me.cls || '' + (' ' + me.extraBaseCls);

which i think should look like

me.cls = (me.cls || '') + (' ' + me.extraBaseCls);

Gary Schlosberg
21 Oct 2013, 6:16 AM
Thanks for the report! I have opened a bug in our bug tracker.