PDA

View Full Version : [FIXED] sparkline.Base - mixed case event name



LesJ
9 Apr 2014, 6:16 AM
Event names are supposed to be case sensitive in Ext JS 5.

I'd think this implies they all will be in lower case, but I found two event names which use mixed case.


Ext.define('Ext.sparkline.Base', {
...
updateDisplay: function () {
...
me.fireEvent('sparklineRegionChange', me); // <-- convert to low case?
...



Ext.define('Ext.data.PageMap', {
...
addPage: function(pageNumber, records) {
...
me.fireEvent('pageAdded', pageNumber, page);
...
},
...

evant
9 Apr 2014, 7:31 AM
The event names shouldn't be case sensitive. So while they should be fixed in the source, Observable needs to ignore case.

LesJ
9 Apr 2014, 7:35 AM
The event names shouldn't be case sensitive. So while they should be fixed in the source, Observable needs to ignore case.

See this comment (http://www.sencha.com/forum/showthread.php?283830-Observable-issue-Uncaught-TypeError-Cannot-call-method-_incr_-of-undefined).

"Are you mixing case in event names? They are case sensitive in 5.x which was the cause of this report"