PDA

View Full Version : [FIXED] missing 'operation' parameter in Ext.data.proxy.Memory#destroy function declaration



rkleinkromhof
17 Apr 2014, 5:46 AM
Fiddle: https://fiddle.sencha.com/#fiddle/562

The function declaration in sencha-core's Ext.data.proxy.Memory#destroy is missing the 'operation' parameter in its function declaration.

From line 125 in sencha-core/src/data/proxy/Memory.js:


destroy: function() {
this.finishOperation(operation);
},

should be:


destroy: function(operation) {
this.finishOperation(operation);
},


The functions finishOperation, create, update and read all correctly have the 'operation' parameter in their declaration.

Additional info:
Ext version tested:

Ext 5.0.0 rev 736




Browser versions tested against:

Chome 34.0.1847.116 m




DOCTYPE tested against:

HTML5




Description:

See above.




Steps to reproduce the problem:

run the fiddle!




The result that was expected:

call to #destroy completed without errors




The result that occurs instead:

got js error: Uncaught ReferenceError: operation is not defined

mitchellsimoens
18 Apr 2014, 5:06 AM
Thanks for the report! I have opened a bug in our bug tracker.

rkleinkromhof
2 Jun 2014, 11:36 PM
It seems this has been fixed in the commercial 5.0.0.970 release and renamed to 'erase' as documented on the Upgrade Guide. See http://docs.sencha.com/extjs/5.0.0/whats_new/5.0/extjs_upgrade_guide.html#Methods under destroy / erase / drop
Thnx, guys!