PDA

View Full Version : [FIXED] Container - unused local variable



LesJ
25 Apr 2014, 11:06 AM
I just noticed that the controller variable is not used, so I thought I'd report it.

Ext.define('Ext.container.Container', {
...
// @private
initComponent: function(){
var me = this,
reference = me.reference,
controller, // <--- unused variable
len;


me.callParent();


me.getLayout();
// Set a flag to say we're constructing children, can be useful
// to know during construction time to save work
me.constructing = true;


if (reference && reference.charAt(len = reference.length - 1) === '>') {
me.isParentReference = true;
me.reference = reference.substring(0, len);
//<debug>
if (!me.validIdRe.test(me.reference)) {
Ext.Error.raise('Invalid component "reference": "' + me.reference + '"');
}
//</debug>
}


me.initItems();
delete me.constructing;
},
...

mitchellsimoens
25 Apr 2014, 11:24 AM
Thanks for the report! I have opened a bug in our bug tracker.

Likely left over from when we moved the ViewController logic from Container to Component.

evant
25 Apr 2014, 2:18 PM
This is already resolved in the current code base.