PDA

View Full Version : [NOREPRO] Ext.mixin.Observable. clearManagedListeners - minor incompatibility with 4.*



LesJ
29 Apr 2014, 7:38 AM
There's a minor incompatibility in the clearManagedListeners method. In 4.x, this method has no return value, but in 5.0 it may return 'this'.

Ext.define('Ext.mixin.Observable', {
...
clearManagedListeners: function(object) {
...
if (object) {
...
delete managedListeners[id];
// return this;
return; // <-- use just return w/o this?
}

for (id in managedListeners) {
if (managedListeners.hasOwnProperty(id)) {
this.clearManagedListeners(id);
}
}
},
...

mitchellsimoens
29 Apr 2014, 7:50 AM
Thanks for the report! I have opened a bug in our bug tracker.