PDA

View Full Version : Grid HeaderContainer border in 4.2.x



Jangla
2 Apr 2015, 4:47 AM
Is there a way to define the header container in a grid panel in 4.2.x? Right now I get this gray border on top of my column header and can't seem to get rid of it unless I use some nasty forced CSS: http://puu.sh/gYOwC/ab9a2a2052.png

Would much rather do it with border: false but can't find the docs on grid header container config.

Gary Schlosberg
6 Apr 2015, 9:56 AM
I'm not sure you can do anything without some CSS. From what theme did you inherit? I'm not seeing a border aside from the grid border:
https://fiddle.sencha.com/#fiddle/krn

Jangla
7 Apr 2015, 12:18 AM
That grey line below the blue one? Not in our current 4.1.1 implementation:

http://puu.sh/h4Adq/bfa22f6673.png

(http://puu.sh/h4Adq/bfa22f6673.pngIt's)It's being added directly to the element: http://puu.sh/h4B5v/e0aa8f3221.png and would therefore require "!important" to override it - YUCK :D

Note that the headerCt has "no-border-left" and "no-border-right": http://puu.sh/h4B7V/3ad59c5674.png

(http://puu.sh/h4B7V/3ad59c5674.pngI)I just want to find out how to ensure it also has "no-border-top" via the grid component's initial config.


Our theme is base on the standard Ext theme with some extremely heavy modding (it was done way before Neptune was a thing).

Gary Schlosberg
7 Apr 2015, 12:11 PM
I see the grey line now, thanks. To which specific 4.2.x version are you upgrading? When I try that Fiddle in various 4.2 versions, I do see the x-docked-noborder-top you mentioned (along with x-docked-noborder-right and x-docked-noborder-left)

52136

Jangla
8 Apr 2015, 12:13 AM
I'm using 4.2.3

Obviously, our grids are pretty complex so there's no doubt some interaction going on that I'm not seeing. While it would be too much for me to post the entire grid code, I can say that in general we use a viewConfig to define getRowClass function and set border to false but other than that, there's nothing I can see that specifically would cause this difference in behaviour between 4.1.1 and 4.2.3

I wonder if there's some difference in the way docked items are implemented? Are you adding toolbars in your fiddle tests?

Gary Schlosberg
8 Apr 2015, 3:07 PM
No toolbars, just the Fiddle listed above. When I do test with a toolbar, the x-docked-noborder-top is not present, rather it shows up in the tbar markup.
52140

Surprisingly though, it seems to be the same with 4.2.3 or 4.1.1.

Jangla
9 Apr 2015, 7:14 AM
In your fiddle, 4.2.3 doesn't work at all for me: http://puu.sh/h7psm/2a3bf27f60.png

A (http://puu.sh/h7psm/2a3bf27f60.png)lso note that I forked your fiddle, added some more options to make it more similar to the kind of setup you might expext in our platform and there's no sign of x-docked-noborder-top in the output. Here's the forked fiddle: https://fiddle.sencha.com/#fiddle/l0m

and here's a screen grab: http://puu.sh/h7pDE/d79b31eccf.png

Jangla
20 Apr 2015, 8:18 AM
Bump

Gary Schlosberg
21 Apr 2015, 3:53 PM
Sorry for the delay. To see a Fiddle running 4.2.3, you must be logged into Fiddle with your forum credentials.

Do you see the same results in that Fiddle?

Jangla
22 Apr 2015, 12:59 AM
Sorry for the delay. To see a Fiddle running 4.2.3, you must be logged into Fiddle with your forum credentials.

Do you see the same results in that Fiddle?

OK, got yours working in 4.2.3 Looks fine.

However, please see my post about the additional options in my fiddle that seem to product the problem with the incorrect CSS classes being applied. My guess is there's some interaction with the viewConfig or the action of adding a docked toolbar above the grid creating the problem.