PDA

View Full Version : [FIXED][3.0.0] Ext.grid.PropertyGrid boolean values do not update



splittingred
10 Jul 2009, 8:32 AM
UPDATE: Proposed solution found.

Ext version tested:

Ext 3.0.0 GA


Adapter used:

ext


Browser versions tested against:

FF 3.5
Safari 4


Operating System:


Mac OS X 10.5.7
WinXP (added by Moderator)


Description:

When selecting a boolean value on an Ext.grid.PropertyGrid on the Mac, it will always end up being false, regardless of the one chosen.


See this URL : http://extjs.com/deploy/dev/examples/grid/property-grid.html

Steps to reproduce the problem:

Go here http://extjs.com/deploy/dev/examples/grid/property-grid.html with either Safari 4 or FF 3.5. Try to change a boolean value from false to true.


The result that was expected:

When selecting 'true', true should be the value selected


The result that occurs instead:

No matter what value is selected, it ends up selecting false


Debugging already done:

record.data.value on 2nd line of Ext.grid.PropertyStore::onUpdate is always set to false, no matter the selection, so seems to be problem with renderer


Proposed solution:

In Ext.grid.PropertyColumnModel, change the getValue definition for the boolean field editor from:


getValue : function(){
return this.el.value == 'true';
}

to:

getValue : function(){
return this.el.dom.value == 'true';
}

mjlecomte
10 Jul 2009, 10:27 AM
Thanks for the report, going to change the title since it happens on XP also.

evant
11 Jul 2009, 7:13 PM
Your solution works, the PropertyGrid is getting the value from the Ext.Element, as opposed to the DOM. Fixed in the trunk.

tdupont
28 Jul 2009, 1:39 PM
I am experiencing this problem as well, only I am using the latest from the Ext 2.x branch.
Should this patch applied to the branch?

evant
28 Jul 2009, 10:21 PM
I've backported the fix to 2.x, grab the latest in SVN.