PDA

View Full Version : [FIXED-75][2.x,3.x SVN] rev. 4913 killed accordion collapse tool



Condor
7 Aug 2009, 3:41 AM
Example: See the examples/layout/accordion.html example in a ext2.0 or trunk SVN build.

Accordion layout adds collapsible:true before rendering the panels. In Ext 2.3 and 3.0.0 the Panel onRender adds a collapse tool if collapsible:true.

SVN rev. 4913 (for this bugreport (http://extjs.com/forum/showthread.php?t=75598)) moved the collapsible:true check from onRender to initComponent, so it is now called before the Accordion layout makes the panel collapsible, resulting in accordion panels without a collapse tool.

The solution that Animal provided in the bugreport would have worked correctly.

evant
9 Aug 2009, 9:43 AM
Fixed in SVN, the check has been moved back to onRender.

Condor
29 Aug 2009, 4:20 AM
Just checked this against todays SVN and it still doesn't work.

IMHO it should be:

if (/*this.header &&*/ this.collapsible && !this.hideCollapseTool) {
this.tools = this.tools ? this.tools.slice(0) : [];
this.tools[this.collapseFirst ? 'unshift' : 'push']({
id: 'toggle',
handler: this.toggleCollapse,
scope: this
});
}
(addTool already checks if the header element exists)

jburnhams
3 Sep 2009, 5:51 AM
Just ran into this bug. Could it be fixed in SVN please?

Drayton
4 Sep 2009, 3:38 AM
I'm also voting for a fix :)

elishnevsky
6 Sep 2009, 7:39 AM
Bump :) Is this one hard to fix?

watrboy00
6 Sep 2009, 5:52 PM
+1

evant
6 Sep 2009, 10:48 PM
Fix applied to svn in rev #5292 for patch release 3.0.2.

Drayton
7 Sep 2009, 5:22 AM
Confirmed working

Thank you